Opened 10 years ago

Closed 10 years ago

Last modified 10 months ago

#9022 closed patch

LoL: Files are always compiled

Reported by: SF/lvzuufx Owned by: lordhoto
Priority: normal Component: Engine: Kyra
Keywords: Cc:
Game: Lands of Lore

Description

HI/2.

saveload_lol.cpp and sound_lol.cpp are always compiled regardless of ENABLE_LOL. After all, compilation failed due to them.

KO Myung-Hun

Ticket imported from: #2796028. Ticket imported from: patches/1127.

Attachments (1)

kyra.diff (669 bytes) - added by SF/lvzuufx 10 years ago.
KYRA LOL patch

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by SF/lvzuufx

Attachment: kyra.diff added

KYRA LOL patch

comment:1 Changed 10 years ago by lordhoto

Owner: set to lordhoto
Status: newclosed
Summary: lol files are always compiledLoL: Files are always compiled

comment:2 Changed 10 years ago by lordhoto

Thanks for the patch. saveload_lol.cpp had some #ifdef guards anyway, so I guess it only failed because of sound_lol.cpp. I extended sound_lol.cpp to also be protected by an #ifdef guard, it should help other build systems apart our configure/Makefile based system to allow disabling the LoL engine properly too.

comment:3 Changed 10 months ago by digitall

Component: Engine: Kyra
Game: Lands of Lore
Note: See TracTickets for help on using tickets.