Opened 11 years ago

Closed 11 years ago

Last modified 17 months ago

#8991 closed patch

Gob engine : Some more MD5s and Fascination's skeleton

Reported by: Strangerke Owned by: Strangerke
Priority: normal Component: Engine: Gob
Keywords: Cc:
Game: Fascination

Description

- Added some more MD5 to the Gob detection engine (Playtoon 1 and 2, Fascination, Geisha) - Added inter and draw skeleton for Fascination - Added a switch to define to first STK to load based on the game type

Ticket imported from: #2725859. Ticket imported from: patches/1096.

Attachments (11)

Gob_Strangerke_090401.patch (27.5 KB ) - added by Strangerke 11 years ago.
GOB: Skeleton for Fascination + MD5s
Gob_Strangerke_090402.patch (25.9 KB ) - added by Strangerke 11 years ago.
Add some code in the 'unknown' functions, plug in the Protracker function, modify parser use to v1, split Playtoon in two, to easy future work
Gob_Strangerke_090402_MD5.patch (2.9 KB ) - added by Strangerke 11 years ago.
Gob: MD5 related modifications
Gob_Strangerke_090403.patch (34.7 KB ) - added by Strangerke 11 years ago.
Gob: Add Windows version of Gob trilogy. Add atypic version of Last dynasty demo
Gob_Strangerke_090403_MD5.patch (5.1 KB ) - added by Strangerke 11 years ago.
Add MD5 for Windows version of Gob trilogy, atypic 'last dynasty' demo and an adibou v4 game
Gob_Strangerke_090406.patch (34.7 KB ) - added by Strangerke 11 years ago.
Change Game id from fascin to fascination, Add a new field in detection array
Gob_Strangerke_090406_MD5.patch (24.8 KB ) - added by Strangerke 11 years ago.
Add a new field in detection array, replace AD_ENTRY1 by AD_ENTRY_1s on added MD5
Gob_Strangerke_090407.patch (35.0 KB ) - added by Strangerke 11 years ago.
Code clean-up
Gob_Strangerke_090407_MD5.patch (28.2 KB ) - added by Strangerke 11 years ago.
Code clean-up
Gob_Strangerke_090407_v2.patch (60.7 KB ) - added by Strangerke 11 years ago.
Gob - Add support to Fascination CD (hand generated Stk files), replace standard initialisation by '0' in order to shorten detection code
Gob_Strangerke_090407_v3.patch (60.6 KB ) - added by Strangerke 11 years ago.
Gob - Fix detection of Playtoon games. Add missing spaces in AD_ENTRY1s calls. Split check of baseTot and baseStk.

Download all attachments as: .zip

Change History (16)

by Strangerke, 11 years ago

Attachment: Gob_Strangerke_090401.patch added

GOB: Skeleton for Fascination + MD5s

comment:1 by Strangerke, 11 years ago

Owner: set to DrMcCoy

by Strangerke, 11 years ago

Attachment: Gob_Strangerke_090402.patch added

Add some code in the 'unknown' functions, plug in the Protracker function, modify parser use to v1, split Playtoon in two, to easy future work

by Strangerke, 11 years ago

Gob: MD5 related modifications

by Strangerke, 11 years ago

Attachment: Gob_Strangerke_090403.patch added

Gob: Add Windows version of Gob trilogy. Add atypic version of Last dynasty demo

by Strangerke, 11 years ago

Add MD5 for Windows version of Gob trilogy, atypic 'last dynasty' demo and an adibou v4 game

comment:2 by DrMcCoy, 11 years ago

Sorry for the late answer.

Anyway, looking good so far. :) Some notes though (most of which I already told you on IRC):

1. There's one tab too many at the switch in gob.cpp 2. Use "fascination" not "fascin" as a game ID for Fascination 3. In the detection array, don't change the capitalization of the game ID 4. One game ID for Fascination ("fascination"), not "fascin" and "fascin2" 5. You should probably introduce a new field in the detection array for the STK that's loaded on game start 6. Likewise, maybe adding a "Features" flag value for "0OT" instead of "TOT" would be prudent as well 7. Use AD_ENTRY1s() instead of AD_ENTRY1() in the detection array, including the size of the data file. So that MD5 collisions can be minimized (especially since only the first 5000 bytes of the files are measured)

by Strangerke, 11 years ago

Attachment: Gob_Strangerke_090406.patch added

Change Game id from fascin to fascination, Add a new field in detection array

by Strangerke, 11 years ago

Add a new field in detection array, replace AD_ENTRY1 by AD_ENTRY_1s on added MD5

by Strangerke, 11 years ago

Attachment: Gob_Strangerke_090407.patch added

Code clean-up

by Strangerke, 11 years ago

Code clean-up

by Strangerke, 11 years ago

Gob - Add support to Fascination CD (hand generated Stk files), replace standard initialisation by '0' in order to shorten detection code

by Strangerke, 11 years ago

Gob - Fix detection of Playtoon games. Add missing spaces in AD_ENTRY1s calls. Split check of baseTot and baseStk.

comment:3 by Strangerke, 11 years ago

Owner: DrMcCoy removed

comment:4 by Strangerke, 11 years ago

Owner: set to Strangerke
Status: newclosed

comment:5 by digitall, 17 months ago

Component: Engine: Gob
Game: Fascination
Note: See TracTickets for help on using tickets.