|Reported by:||SF/reddwarf69||Owned by:||wjp|
From openSUSE rpmlint... I: Statement might be overflowing a buffer in strncat. Common mistake: BAD: strncat(buffer,charptr,sizeof(buffer)) is wrong, it takes the left over size as 3rd argument GOOD: strncat(buffer,charptr,sizeof(buffer)-strlen(buffer)-1) E: scummvm bufferoverflowstrncat engines/saga/sfuncs.cpp:1573 E: scummvm bufferoverflowstrncat engines/scumm/he/logic_he.cpp:89
No especially efficient (too much strlen()) but fixes the problem.
Ticket imported from: #2671477. Ticket imported from: patches/1080.