Opened 15 years ago

Closed 15 years ago

Last modified 6 years ago

#8952 closed patch (wontfix)

NDS: Cleanup of the file I/O code

Reported by: fingolfin Owned by: agent-q
Priority: normal Component: Port: NDS
Version: Keywords:
Cc: Game:


The attached patch represents a first step to cleaning up the Nintendo DS port's file/FS code. It moves the stdio emulation code into its own Common::Stream subclass. Based on that, it should be possible to (a) simplify this stream emulation code, (b) make it actually more compliant with std I/O behavior (which might fix the one or other obscure bug in the NDS port?), and (c) would allow to cleanup the rest of the NDS port nicely.

Ticket imported from: #2594629. Ticket imported from: patches/1057.

Attachments (1)

ds-stream.patch (24.6 KB ) - added by fingolfin 15 years ago.
First step

Download all attachments as: .zip

Change History (7)

by fingolfin, 15 years ago

Attachment: ds-stream.patch added

First step

comment:1 by fingolfin, 15 years ago

Neil, any comments on this one?

comment:2 by agent-q, 15 years ago

Resolution: wontfix

comment:3 by agent-q, 15 years ago

Sorry, I've already implemented this code and it is currently waiting to be committed. I did this in order to add caching as saving the scummvm.ini file was taking around 20 seconds with the exisiting code (since the file is now written a byte at a time). So thanks for your work on this but this patch is not required.

comment:4 by fingolfin, 15 years ago

Fair enough. Now if you just would commit that code... :-).

comment:5 by fingolfin, 15 years ago

Status: newclosed

comment:6 by digitall, 6 years ago

Component: Port: NDS
Note: See TracTickets for help on using tickets.