Opened 12 years ago

Closed 12 years ago

Last modified 2 years ago

#8937 closed patch

Groovie engine

Reported by: spookypeanut Owned by: fingolfin
Priority: normal Component: Engine: Groovie
Keywords: Cc:
Game: 7th Guest

Description

Currently only The 7th Guest works at all, though several others are detected.

mscv files not patched atm, can attach a patch for them when the only Windows person on our team wakes up :-)

Ticket imported from: #2271425. Ticket imported from: patches/1042.

Attachments (2)

groovie.patch (167.0 KB ) - added by spookypeanut 12 years ago.
groovie engine patch
groovie2.patch (150.5 KB ) - added by spookypeanut 12 years ago.
updated patch

Download all attachments as: .zip

Change History (9)

by spookypeanut, 12 years ago

Attachment: groovie.patch added

groovie engine patch

comment:1 by spookypeanut, 12 years ago

Ooops, should have said, for reference, this is from ScummVM r35023 and t7gre r332.

comment:2 by sev-, 12 years ago

Overall it looks nice. Just couple of remarks:

* replace printf()'s with debug(N, "...") for printfs in Script::o_othello() there is debugN(N, "...") * JPEG reader should go to graphics/ directory as it is a common format

That basically it. If you want me to be nit-picky, I noticed mix of C and C++-style comments here and there, as well as mix of vertical spacing, i.e. pretty often there is no empty line after function local variable declarations which we usually do,

by spookypeanut, 12 years ago

Attachment: groovie2.patch added

updated patch

comment:3 by spookypeanut, 12 years ago

Who ever said we wanted you to be picky? ;-) OK, Here's an updated one: * printf()s removed * jpeg code removed (it's not used in t7g, or even 11h (for which it was developed) at the moment, and we figured until we definitely need it best not to commit it to ScummVM) * I've fixed a little of the vertical spacing, and I'll bear it in mind when I'm working on the code in future and correct it as I go along! File Added: groovie2.patch

comment:4 by SF/arablizzard2413, 12 years ago

http://pastebin.ca/1255947

Here's the msvc project files for 7, 7.1, 8, and 9.

comment:5 by fingolfin, 12 years ago

Owner: set to fingolfin
Status: newclosed

comment:6 by fingolfin, 12 years ago

Added to Subversion. Somebody should update the NEWS file.

comment:7 by digitall, 2 years ago

Component: Engine: Groovie
Game: 7th Guest
Note: See TracTickets for help on using tickets.