#8937 closed patch
Groovie engine
| Reported by: | spookypeanut | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Groovie |
| Version: | Keywords: | ||
| Cc: | Game: | 7th Guest |
Description
Currently only The 7th Guest works at all, though several others are detected.
mscv files not patched atm, can attach a patch for them when the only Windows person on our team wakes up :-)
Ticket imported from: #2271425. Ticket imported from: patches/1042.
Attachments (2)
Change History (9)
by , 16 years ago
| Attachment: | groovie.patch added |
|---|
comment:1 by , 16 years ago
Ooops, should have said, for reference, this is from ScummVM r35023 and t7gre r332.
comment:2 by , 16 years ago
Overall it looks nice. Just couple of remarks:
* replace printf()'s with debug(N, "...") for printfs in Script::o_othello() there is debugN(N, "...") * JPEG reader should go to graphics/ directory as it is a common format
That basically it. If you want me to be nit-picky, I noticed mix of C and C++-style comments here and there, as well as mix of vertical spacing, i.e. pretty often there is no empty line after function local variable declarations which we usually do,
comment:3 by , 16 years ago
Who ever said we wanted you to be picky? ;-) OK, Here's an updated one: * printf()s removed * jpeg code removed (it's not used in t7g, or even 11h (for which it was developed) at the moment, and we figured until we definitely need it best not to commit it to ScummVM) * I've fixed a little of the vertical spacing, and I'll bear it in mind when I'm working on the code in future and correct it as I go along! File Added: groovie2.patch
comment:4 by , 16 years ago
http://pastebin.ca/1255947
Here's the msvc project files for 7, 7.1, 8, and 9.
comment:5 by , 16 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:7 by , 6 years ago
| Component: | → Engine: Groovie |
|---|---|
| Game: | → 7th Guest |
groovie engine patch