#8930 closed patch (invalid)
GUI: Don't Reset File Directories
| Reported by: | SF/mthreepwood | Owned by: | SF/tanoku |
|---|---|---|---|
| Priority: | normal | Component: | GUI |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
ThemeEngine::unloadTheme calls Common::File::resetDefaultDirectories() which doesn't make sense to me. This really screwed me up with Mohawk (it took a while to track down why it couldn't find some files after already opening them :P). Perhaps there's a reason behind this that I don't see? Anyway, here's a simple patch that just removes that line.
Ticket imported from: #2175630. Ticket imported from: patches/1035.
Attachments (1)
Change History (5)
by , 16 years ago
| Attachment: | remove_directory_reset.diff added |
|---|
comment:1 by , 16 years ago
| Owner: | set to |
|---|
comment:2 by , 16 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
comment:3 by , 16 years ago
Removing resetDefaultDirectories() altogether would have broken theme reloading. We needed to remove the dependency on Common::File default paths for image/font loading. Fixed in revision 34815.
comment:4 by , 6 years ago
| Component: | → GUI |
|---|
Note:
See TracTickets
for help on using tickets.
Patch