Opened 11 years ago

Closed 11 years ago

Last modified 13 months ago

#8914 closed patch

SCUMM: engine sets incorrect talkspeed value

Reported by: salty-horse Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

Scumm's talkspeed value is set by the value of _defaultTalkDelay.

This is confusing since the setting is called "subtitle speed". A value of 9 should mean "fastest speed" and not "largest delay" (i.e. slowest speed) as it currently does.

Also, since the the +/- hotkey OSD shows the value of "9 - _defaultTalkDelay", it is inconsistent with the display in the Scumm options menu which shows _defaultTalkDelay.

The patch adjusts the talkspeed value to be "9 - _defaultTalkDelay".

Ticket imported from: #2060517. Ticket imported from: patches/1019.

Attachments (3)

scumm-talkspeed-slider.patch (875 bytes ) - added by salty-horse 11 years ago.
scumm-talkspeed-slider-2.patch (1.6 KB ) - added by salty-horse 11 years ago.
Corrected patch. Added missing files.
scumm-talkspeed-slider-3.patch (2.7 KB ) - added by salty-horse 11 years ago.
Third patch. Isolated changes to the get/set funcs

Download all attachments as: .zip

Change History (14)

by salty-horse, 11 years ago

comment:1 by fingolfin, 11 years ago

Sounds sensible all in all. Will review the patch later, when I have a break on this conference.

comment:2 by fingolfin, 11 years ago

Owner: set to fingolfin
Summary: [SCUMM] engine sets incorrect talkspeed valueSCUMM: engine sets incorrect talkspeed value

comment:3 by salty-horse, 11 years ago

Uploaded a new patch. Kirben pointed out a few missing function calls.

comment:4 by salty-horse, 11 years ago

SF.net seems to be having trouble with file uploading, so here's a temporary copy of the patch:
http://paste.lisp.org/display/65809/raw

comment:5 by fingolfin, 11 years ago

Attachment problems should be fixed now, please attache the missing files. Thanks!

by salty-horse, 11 years ago

Corrected patch. Added missing files.

comment:6 by salty-horse, 11 years ago

Attached! (hopefully)
File Added: scumm-talkspeed-slider-2.patch

comment:7 by fingolfin, 11 years ago

If you change all occurrences of
getTalkspeed()
to
9 - getTalkspeed()
then it would be much easier to change *none* of them, but rather change the code of getTalkspeed(). Same for setTalkspeed().

comment:8 by salty-horse, 11 years ago

Oh, Right :/
Then I'll change get/setTalkspeed to get/setTalkDelay.

by salty-horse, 11 years ago

Third patch. Isolated changes to the get/set funcs

comment:9 by salty-horse, 11 years ago

Attached a new patch.
File Added: scumm-talkspeed-slider-3.patch

comment:10 by fingolfin, 11 years ago

Status: newclosed

comment:11 by digitall, 13 months ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.