Opened 11 years ago

Closed 11 years ago

Last modified 13 months ago

#8905 closed patch

XMIDI callback control events

Reported by: eriktorbjorn Owned by: eriktorbjorn
Priority: normal Component: Audio: MT32
Keywords: Cc:
Game: Simon the Sorcerer 2

Description

This patch should be enough to implement the XMIDI callback controller event. Basically, it just adds some optional parameters to createParser_XMIDI(), so that a callback function can be specified.

However, I'm a bit torn... The main reason (for me) would be to silence the warnings in the DOS version of Simon the Sorcerer 2. This is fine, because the game doesn't actually seem to *use* the callback events. But it would also silence the warnings for games where we want the warning, because some feature is actually missing.

So maybe there should be a default callback that prints a message, and any engine that doesn't want this would have to explicitly say so?

Ticket imported from: #2040074. Ticket imported from: patches/1010.

Attachments (2)

xmidi.diff (3.7 KB ) - added by eriktorbjorn 11 years ago.
Patch against current SVN
xmidi2.diff (4.7 KB ) - added by eriktorbjorn 11 years ago.
Updated patch against current SVN

Download all attachments as: .zip

Change History (7)

by eriktorbjorn, 11 years ago

Attachment: xmidi.diff added

Patch against current SVN

comment:1 by sev-, 11 years ago

Yes, default callback makes sense, and you may even make it truly default, i.e. as a default parameter value (pardon the pun). Could you implement that too?

by eriktorbjorn, 11 years ago

Attachment: xmidi2.diff added

Updated patch against current SVN

comment:2 by eriktorbjorn, 11 years ago

You mean something like this?
File Added: xmidi2.diff

comment:3 by sev-, 11 years ago

Exactly. Feel free to commit it.

comment:4 by eriktorbjorn, 11 years ago

Owner: set to eriktorbjorn
Status: newclosed

comment:5 by digitall, 13 months ago

Component: Audio: MT32
Game: Simon the Sorcerer 2
Note: See TracTickets for help on using tickets.