Opened 12 years ago

Closed 12 years ago

Last modified 13 months ago

#8856 closed patch

set defaultTo1XScaler depending on width with CJK mode

Reported by: SF/lvzuufx Owned by: sev-
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

Hi/2.

When CJK mode, defaultTo1XScaler set to true. But it is better to set its value depending on width, which is _screenWidth * _textSurfaceMultiplier.

KO Myung-Hun

Ticket imported from: #1949695. Ticket imported from: patches/961.

Attachments (1)

defaultTo1XScaler.diff (599 bytes ) - added by SF/lvzuufx 12 years ago.

Download all attachments as: .zip

Change History (8)

by SF/lvzuufx, 12 years ago

Attachment: defaultTo1XScaler.diff added

comment:1 by sev-, 12 years ago

Owner: set to sev-
Resolution: outdated
Status: newclosed

comment:2 by sev-, 12 years ago

This has already been fixed in SVN. Your patch looks to be agains quite old version of ScummVM, it is not even 0.11.1. It is always best to check against trunk, not some old release.

comment:3 by SF/lvzuufx, 12 years ago

Hi/2.

I confirmed already tar ball for 0.11.1 and SVN trunk. But both of them have the same code. In addition, my code is based on 0.11.1. Please check again.

KO Myung-Hun

comment:4 by sev-, 12 years ago

Resolution: outdated

comment:5 by sev-, 12 years ago

Well, there was what I consider as a hack for DIG, since that was only Japanese Game I had access to. But then I remembered that there are Korean Dig and Full Throttle, so that made your approach more elegant.

I committed slightly altered version of your patch (code formatting fixed), removed my DIG-related hack and added a descriptive comment

comment:6 by SF/lvzuufx, 12 years ago

Thanks. ^^

comment:7 by digitall, 13 months ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.