Opened 12 years ago

Closed 12 years ago

Last modified 13 months ago

#8854 closed patch

Digital Audio Kyrandia Soundtrack Replacement

Reported by: SF/pix2 Owned by: lordhoto
Priority: normal Component: Engine: Kyra
Keywords: Cc:
Game:

Description

This patch adds an ogg replacement soundtrack for Legend of Kyrandia recorded from an MT-32. I've added a "digital midi replacement" driver to the list of audio drivers. The oggs themselves are at:-

http://pix.www.idnet.com/lokoggs.rar

Ticket imported from: #1942384. Ticket imported from: patches/959.

Attachments (1)

lok.patch (25.4 KB ) - added by SF/pix2 12 years ago.

Download all attachments as: .zip

Change History (15)

by SF/pix2, 12 years ago

Attachment: lok.patch added

comment:1 by sev-, 12 years ago

Looks good to me except adding SVN keywords and reformatting couple of lines in SoundDigitalMidi::playSoundEffect().

Johannes, it's up to you now.

comment:2 by sev-, 12 years ago

Owner: set to lordhoto

comment:3 by lordhoto, 12 years ago

Eugene/Max: I wonder about one thing, the agos engine auto detects enhanced music (a.k.a. midi replacement in this case), while this patch introduces a new music driver selection in the GUI, shouldn't we then change AGOS engine to use that too? Or change this patch to do something similar to the AGOS engine?

Nitpicking about formatting: Some lines include spaces instead of tabs, that would be neat if you could fix it first.

Apart from that I'm fine with it. So thanks for posting that patch.

comment:4 by Kirben, 12 years ago

I really don't think this patch should be added to ScummVM:
1. The FM-TOWNS (And PC98?) versions of the Legend of Kyrandia already offer majority of music, via CD audio.
2. Permission have not been given by Electronic Arts, to even redistribute the music of this game.
3. This will only encourage people to ask for similar support, in other games/game engines. Especially due to the method (Additional digital driver) used by this particular patch.

I would be surprised if this didn't cause more piracy of the CD audio used by FM-TOWNS and (PC98?) versions of this game too, with people complaining that not all music is been played by ScummVM.

comment:5 by lordhoto, 12 years ago

About PC-98(21) version, it includes CD audio. At least the CD version, there seems to be a 16(?) color version for PC98 coming on floppy disks though, but I wasn't able to find any information about it, except some screenshots.

Others are valid points. Thinking about it again, I agree that we should have at least permissions from EA for that.
About 3 I think the problem here might really be the method with the digital output driver in the audio options, apart I don't really see a big difference between what AGOS did with enhanced Simon1 soundtrack and this.

comment:6 by SF/pix2, 12 years ago

The point about permissions is fair enough. I doubt EA would have a problem with this – the difficulty would be getting any sort of response at all. Is this something I would have to chase up myself?

I don’t agree with 1 or 3 though. I don't see that the fm-towns and pc98 having cd audio comes into this. Not many people will ever own legal copies of either whereas a dos version is easy enough to get hold of. If anything this patch should discourage piracy of those versions.

Is it a problem if people want the same feature in other games? I wouldn't mind working on that myself. The reasoning here seems to be that people will want this feature so lets not give it to them.

comment:7 by lordhoto, 12 years ago

Well point 3 _is_ valid, since for some games it may not possible to do (for example iMuse games), for others it might be difficult and trust me if it seems you officially try to support such things, people will start crying for it all day long and sometimes even ignoring facts why it can't be done :-). Also of course not every company is fine with it, I would guess LucasArts wouldn't give you permissions for that for example. Also it's not really something inside the scope of ScummVM, the aim of the project is to make the games playable on modern systems such as Linux etc. not for enhancing them with digital audio etc.

About EA: We could ask Endy to talk with them about that, but if you are able to work that out yourself it would be fine too.

comment:8 by lordhoto, 12 years ago

To make my position clear again: I'm fine with this patch in general, BUT if there are complaints from other engine developers or our project leads I will not commit it for now, until we found decision on how to handle such patches in the future. (Which seems to be the case with Kirben currently)

comment:9 by SF/pix2, 12 years ago

Unless I hear otherwise, I'll take it then that this will probably be accepted eventually (maybe after removing the extra audio driver option) provided I can get some sort of EA approval. I've attempted to contact EA - I'll wait and see if they get back to me.

comment:10 by Kirben, 12 years ago

Continuing discussion about point 1:
Well the CD audio of the FM-TOWNS and PC98 versions is an advantage, adding support for digital audio for all versions of this game, could be seen as devaluing the FM-TOWNS and PC98 versions of these games (Although they aren't sold by companies anymore).

The fact the FM-TOWNS and PC98 versions of games aren't as common is irrelevant. They can still usually be found via places (eBay or Yahoo auctions), if people are patient and want them.

The FM-TOWNS and PC98 versions don't have full speech, so I still think this patch would encourage their piracy, specifically for use of the included CD audio.

Finally improving the Roland MT32 emulation, and finding a legal method of use buying/using the roms (without purchasing Roland cards), would be a much better way, to improve the music support of many games at once in ScummVM. Instead of adding additional code, for the use of alternative music files, to many different games engines.

comment:11 by SF/pix2, 12 years ago

I gather other people have tried to find a legal way to use the Roland roms and failed and objections were explicitly raised by them when the emulator was added to dosbox. I'm hardly going to be able to talk them round. Besides which, my goal here was to get decent sound on my PSP, which isn't nearly powerful enough to run an MT-32 emulator.

This hardly devalues the other versions. It just plays the PC game with the exact same sound it came with.

comment:12 by SF/pix2, 12 years ago

I've finally received a reply from EA which was :-

Thank you for your request. While we appreciate your interest in Legend of Kyrandia 1 & 2, EA is not authorizing use of a patch which allows recording of the orginal soundtrack to be played.

An appropriate response would have been nice after waiting weeks. I can create and use a patch to do anything I like, it was just whether I can distribute the soundtrack to anyone else that was under question - a soundtrack that is already freely available on the internet at the request of the composer at that. At any rate, I guess that ends all chances of me getting this approved.

comment:13 by SF/pix2, 12 years ago

Status: newclosed

comment:14 by digitall, 13 months ago

Component: Engine: Kyra
Note: See TracTickets for help on using tickets.