Opened 12 years ago

Closed 12 years ago

Last modified 2 weeks ago

#8769 closed patch

KYRA2: correct platform and talkie flags for sequence player

Reported by: athrxx Owned by:
Priority: normal Component: Engine: Kyra
Keywords: Cc:
Game: Kyrandia 2

Description

This patch corrects the platform and talkie flags within the sequence player (I have now checked the disasms for all three floppy versions, too).

I also got rid of seq_generateFixedRandomValue() and used _rdn.getRandomNumberRng() for the final ("frash") sequence. My first assumption that the towns and floppy versions might use a non initialized random number generator (thus always generating exactly the same values) was wrong. It still makes no sense to me that the sequence playback time is determined at random here, but I even played through the original towns version to verify this. Only the DOS CD-ROM version has a fixed playback time which exactly matches the song length.

Florian

Ticket imported from: #1864214. Ticket imported from: patches/874.

Attachments (1)

sequencesFlags.patch (11.5 KB ) - added by athrxx 12 years ago.
correct platform and talkie flags for sequence player

Download all attachments as: .zip

Change History (5)

by athrxx, 12 years ago

Attachment: sequencesFlags.patch added

correct platform and talkie flags for sequence player

comment:1 by lordhoto, 12 years ago

Status: newclosed

comment:2 by lordhoto, 12 years ago

Thanks for the patch, committed without modification.

comment:3 by digitall, 12 months ago

Component: Engine: Kyra

comment:4 by Thunderforge, 2 weeks ago

Game: Kyrandia 2
Note: See TracTickets for help on using tickets.