Opened 16 years ago

Closed 16 years ago

Last modified 6 years ago

#8763 closed patch

BUILD: Plugin building cleanup

Reported by: lordhoto Owned by: sev-
Priority: normal Component: --Other--
Version: Keywords:
Cc: Game:


This patch aims at improving our plugin building. It changes some things:

- Remove dependency on $(EXECUTABLE) while building plugins on Linux and FreeBSD, this prevents relinking of plugins when changing sources inside the main ScummVM codebase. For changes on the API (that means: in header files included in the engines code), the plugins are rebuild anyway, so it didn't look reasonable to relink the plugins when none of those had been touched but some other code inside the main ScummVM sources.

- Added 'wrapper' API for zlib (check common/zlib.[h/cpp]), this allows us to remove the need for plugins to link against libz, which was needed on some platforms (Win32/MinGW for example). Since I don't have access to a system with MinGW currently someone with MinGW should test it, but theoretically it should work.

I'm assigning this to Fingolfin since he's in charge of our build system. The part about MinGW should be more interesting for Kirben as builder for the Win32 binaries though. Still I would like to know what you think of adding such a 'wrapper' for zlib.

Ticket imported from: #1858158. Ticket imported from: patches/868.

Attachments (1)

plugin-v1.patch (6.0 KB ) - added by lordhoto 16 years ago.

Download all attachments as: .zip

Change History (8)

by lordhoto, 16 years ago

Attachment: plugin-v1.patch added

comment:1 by lordhoto, 16 years ago

A little update: As Kirben told me now it works fine with MinGW.

comment:2 by fingolfin, 16 years ago

Owner: changed from fingolfin to sev-

comment:3 by fingolfin, 16 years ago

Addin a zlib wrapper API is the way to go, I am all for it. The one you added is minimal, which is good, too -- we should only add more stuff as (if) we need it.

So this patch looks good to me. But we are in a feature freeze. I'd say it should be OK to let this slip by, but our release manager Eugene should say yay or nay ;)

comment:4 by fingolfin, 16 years ago

Owner: changed from sev- to fingolfin

comment:5 by sev-, 16 years ago

Owner: changed from fingolfin to sev-
Status: newclosed

comment:6 by sev-, 16 years ago

Sigh, another patch which I noticed too late. Committed to both branch and trunk

comment:7 by digitall, 6 years ago

Component: --Other--
Note: See TracTickets for help on using tickets.