Opened 12 years ago

Closed 12 years ago

Last modified 13 months ago

#8759 closed patch

INDY3 Mac: Grail Diary Fix

Reported by: SF/mthreepwood Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Indiana Jones 3

Description

This fixes bug #1509509. It appears that the macintosh version of Indy3 needs ignoreCharsetMask to be false if the character is black (as it is in the diary). No idea if this is 100% correct to do, but it fixes it for me (albeit with the text shifted over a bit too far, but that's a separate issue).

Ticket imported from: #1851568. Ticket imported from: patches/864.

Attachments (2)

Indy3_Mac_Diary.diff (615 bytes ) - added by SF/mthreepwood 12 years ago.
patch
Indy3_Mac_Diary2.diff (1.9 KB ) - added by SF/mthreepwood 12 years ago.
updated patch

Download all attachments as: .zip

Change History (10)

by SF/mthreepwood, 12 years ago

Attachment: Indy3_Mac_Diary.diff added

patch

by SF/mthreepwood, 12 years ago

Attachment: Indy3_Mac_Diary2.diff added

updated patch

comment:1 by SF/mthreepwood, 12 years ago

Summary: INDY3 Mac: (Partial) Diary FixINDY3 Mac: Grail Diary Fix

comment:2 by SF/mthreepwood, 12 years ago

Updated. I fixed positions of all the text in the diary.

The only text not showing in the game is the biplane manual (room 74). I believe this is a different issue.
File Added: Indy3_Mac_Diary2.diff

comment:3 by fingolfin, 12 years ago

Owner: set to fingolfin
Status: newclosed

comment:4 by fingolfin, 12 years ago

Added a slightly modified version to the repository.

It would be nice to know why the text has to be shifted via a hack, though. But I guess for now it's better to have the hack than nothing.

comment:5 by SF/mthreepwood, 12 years ago

I'm not sure why myself, but without it the text is all over to the right. I think it *may* have something to do with the font. No idea though.

comment:6 by criezy, 12 years ago

I tried the updated patch on CVS snapshot from today (December 16, 2007) with my Mac EGA version.
Now the text appears to be OK in the grail diary (it is visible and it seems to be in the correct place).

However either my memory and my english are a bit rusty (which is possible, I didn't play at Indy 3 for a look time) or the text is not correct. For me it says "If ye would enter, follow the third on the right" while the slab I have to break in the number V (right in the middle). Do I miss something in the message or is there a bug there?

Also I am not quite sure where the version I used comes from. I found it on my hard disk and my guess is that I copied it there from the floppies a long time ago. Just to make sure I will hunt down my floppy version and try again.

comment:7 by criezy, 12 years ago

Sorry for my previous comment, the text is correct but somehow I forgot I had to look at the stone pillar and the third number on the stone pillar on the right is indeed V.

So I confirm this patch does fix the issue for me.

comment:8 by digitall, 13 months ago

Component: Engine: SCUMM
Game: Indiana Jones 3
Note: See TracTickets for help on using tickets.