Opened 12 years ago

Closed 12 years ago

Last modified 11 months ago

#8756 closed patch

Several enhancements in /media

Reported by: jvprat Owned by: fingolfin
Priority: normal Component: Video
Keywords: Cc:
Game:

Description

I'm attaching some images I've modified in /media/trunk:

- scummvm_icon.svg: I've separated it into layers, so it's easier to work with it, and it also includes a blurred shadow as discussed in patch #1836150 (I couldn't post it there)

- Makefile: it includes some rules to automatically generate the scummvm_#.png from scummvm_icon.svg by calling inkscape. I'm also including the output files I got (note that comparing those with the current ones there are some differences. It's because of the way the .svg was done. If you feel the differences are unacceptable, the svg file should be redone). One could include more rules to generate the .ico and .xpm files, so they are all consistent with the current .svg

- scummvm_logo.svg: I've separated it into layers, so it's easier to work with it, and I've included a new layer with the "lowcolor" version, so you have both images in one file (you just have to hide the bitmap contents to get the "lowcolor" version), so the "_lowcolor" file could be removed.

Ticket imported from: #1847604. Ticket imported from: patches/861.

Attachments (2)

media.tgz (206.0 KB ) - added by jvprat 12 years ago.
Makefile (383 bytes ) - added by jvprat 12 years ago.
Updated Makefile

Download all attachments as: .zip

Change History (15)

by jvprat, 12 years ago

Attachment: media.tgz added

comment:1 by fingolfin, 12 years ago

I think your 16 / 32 pixel icons look *better* than what we have, so no problem there :)

I think it's a good idea to have a Makefile. However, I would consider basing it on ImageMagick's "convert" instead, if that's sanely possible. That way, we could also generate the .ico's with almost identical commands. And for that matter also the .xpm, although I am not sure that's so cool... ,)
Alternatively, use inkscape as it is right now, but still use ImageMagick to create the .ico files. Hm, I wonder whether there is a portable tool to generate the .icns file for Mac OS X.

As for the layer changes etc., a good idea.

Eugene, can we commit this? If we do, we should make sure to also update *all* icon files in the icons/ dir in the ScummVM trunk.

comment:2 by fingolfin, 12 years ago

Owner: set to sev-

comment:3 by jvprat, 12 years ago

Nice, I didn't know ImageMagick supported vector formats :) I've done a fast test and version 6.3.5 doesn't seem to support the shadow blurring and it paints over a non-transparent background. So maybe it could be used to generate the resized icons, but it doesn't look ready for the original rasterization (maybe I'm using an old version of it?). I'll try to have a look at this.

I also tried creating the .ico files, but since those can (and I think they _should_) contain several sizes/bpp, the best tool I found to automatically generate it was png2ico (http://www.winterdrache.de/freeware/png2ico/index.html), but it would probably need ImageMagick to preprocess the several sub-images. Let me know if you're aware of any better tool for this.

As for the updating of other parts of the tree, maybe it could be done from the same makefile? For example, favicon.ico on web/trunk could probably be updated the same way.

comment:4 by fingolfin, 12 years ago

I don't think we need to update favicon.ico that often... then again, the rest of the icon shouldn't have to be updated that often either ;)

I don't know of a better utility for .ico creation -- and strictly speaking, this feature goes beyond this patch (i.e. it would be unfair to demand this extra functionality here). I just think it would make sense to do it, it eases our life on the long run. But for now, adding a corresponding TODO to the Makefile would be sufficient, too.

Still waiting for Eugene to comment. This is clearly a "feature change" (a modified icon just before a release -- so we would have to make sure all ports get updated...). Eugene, I'd be willing to work on this (ensure all icon formats are refreshed, and poking porters to update), but maybe we do want to postpone it till after 0.11.0. It's not *that* important, after all.

comment:5 by sev-, 12 years ago

Max, go ahead, and put it into both trunk and branch

comment:6 by sev-, 12 years ago

Owner: changed from sev- to fingolfin

comment:7 by fingolfin, 12 years ago

I will work on this tonight.

by jvprat, 12 years ago

Attachment: Makefile added

Updated Makefile

comment:8 by jvprat, 12 years ago

The attached makefile just uses Inkscape to rasterize the higher resolution version and later it uses ImageMagick's convert to generate lower resolution pngs and the xpm. It still lacks the conversion into .ico and other formats.
File Added: Makefile

comment:9 by fingolfin, 12 years ago

Status: newclosed

comment:10 by fingolfin, 12 years ago

Great, added. Will update the icons tomorrow.

comment:11 by jvprat, 12 years ago

Just as a reminder, scummvm_logo_lowcolor.svg can be deleted if desired, since it's included into scummvm_logo.svg

comment:12 by fingolfin, 12 years ago

Some notes:
* multi frame .icos *are* possible with ImageMagick (see the modified Makefile I commited yesterday)
* there are problems converting PNG to ico, though, where it looses the mask data. This can be avoided by making an intermediate step via GIF. Odd
* Inkscape 0.45 or newer is *required* since filters were not available befor that.

comment:13 by digitall, 11 months ago

Component: Video
Note: See TracTickets for help on using tickets.