Opened 12 years ago

Closed 12 years ago

Last modified 11 months ago

#8755 closed patch

Several enhancements for the build system

Reported by: jvprat Owned by: fingolfin
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

The attached patch tries to enhance several parts of the build system:

- It removes the obsolete and broken "dist" target

- It adds a new "dist-src" target which builds the source tarballs and zip (inspired on tools/dist-scummvm.sh, which also looks obsolete now). It also decides the name of the file depending on the version (the snapshot date for *svn versions, and the version number otherwise)

- It reduces the number of files which include the version number, by extracting this information from base/internal_version.h:
- dists/{macosx|iphone}/Info.plist can be generated on demand by the makefile, so those could be removed from svn
- backends/platform/ds/arm9/makefile gets this information when including Makefile.common, so the makefile.in could be removed from svn (I haven't tried it)

I was also thinking on splitting ports.mk, so just the part of the current port gets included, and each one could define "dist", "install" or "deploy" targets, in order to unify the usage, but this would need deeper changes, so I preferred not touching it by now. Would you be interested on this?

Ticket imported from: #1847599. Ticket imported from: patches/860.

Attachments (1)

makefiles.patch (7.1 KB ) - added by jvprat 12 years ago.

Download all attachments as: .zip

Change History (5)

by jvprat, 12 years ago

Attachment: makefiles.patch added

comment:1 by fingolfin, 12 years ago

Actually, the primary reason I split off ports.mk was that I planned to eventually separate it into multiple files ;). I just didn't want to do this needlessly before a major release.

Otherwise, what you describe here sounds good (but I did not actually review it, lacking time)

comment:2 by fingolfin, 12 years ago

Added, thanks!

comment:3 by fingolfin, 12 years ago

Owner: set to fingolfin
Status: newclosed

comment:4 by digitall, 11 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.