Opened 12 years ago

Closed 11 years ago

Last modified 7 months ago

#8747 closed patch

SWORD 1: inverse stereo for traffic in rue Jarry

Reported by: SF/richiefs Owned by: eriktorbjorn
Priority: normal Component: Engine: Sword1
Keywords: Cc:
Game: Broken Sword 1

Description

Here is a patch that implements the FR #1266599

Ticket imported from: #1833038. Ticket imported from: patches/852.

Attachments (3)

sword1-traffic-jarry.diff (819 bytes) - added by SF/richiefs 12 years ago.
sword1-traffic-jarry.diff
sword1-traffic-jarry-ressources.diff (1008 bytes) - added by SF/richiefs 12 years ago.
sword1-traffic-jarry-ressources.diff
fxlist.diff (717 bytes) - added by eriktorbjorn 11 years ago.
Alternative patch

Download all attachments as: .zip

Change History (17)

Changed 12 years ago by SF/richiefs

Attachment: sword1-traffic-jarry.diff added

sword1-traffic-jarry.diff

comment:1 Changed 12 years ago by SF/richiefs

Link to the FR:
http://sourceforge.net/tracker/index.php?func=detail&aid=1739042&group_id=37116&atid=418823

comment:2 Changed 12 years ago by SF/richiefs

Good link...:
http://sourceforge.net/tracker/index.php?func=detail&aid=1266599&group_id=37116&atid=418823

comment:3 Changed 12 years ago by fingolfin

Owner: set to eriktorbjorn

comment:4 Changed 12 years ago by fingolfin

Torbjörn, could you take a look at this, if you have the time? Thanks!

comment:5 Changed 12 years ago by eriktorbjorn

It would probably make sense to use the FX_ constants for the sounds, as defined in swordres.h instead of hard-coding the values. But if it's simply that the "left-to-right" and "right-to-left" sound effects havebeen mixed up, wouldn't it be simpler to just fix _fxList[] in swordres.cpp? Or are they used elsewhere for something that's visible on screen?

Changed 12 years ago by SF/richiefs

sword1-traffic-jarry-ressources.diff

comment:6 Changed 12 years ago by SF/richiefs

I updated the patch. It doesn't have anymore hard coded values.
I have no idea if these samples are called elsewere.
File Added: sword1-traffic-jarry-ressources.diff

comment:7 Changed 11 years ago by fingolfin

Owner: changed from eriktorbjorn to lavosspawn

comment:8 Changed 11 years ago by fingolfin

Torbjörn, how about doing as you said and fix _fxList[], and we'll find out if that's wrong when somebody complains?

Maybe Robert also has something to add?

Changed 11 years ago by eriktorbjorn

Attachment: fxlist.diff added

Alternative patch

comment:9 Changed 11 years ago by eriktorbjorn

Here's what the alternative patch would look like. I have assumed that the symbolic name in _fxList[] is correct - for instance, "Truck passes, left to right" is called FX_HVYVEHR, because the truck is travelling to the "R"ight - and changed the #defines instead.

If it doesn't break any other scene, I think it's a much more elegant way of fixing the glitch.
File Added: fxlist.diff

comment:10 Changed 11 years ago by fingolfin

Go ahead and commit it, I'd say. And close both this and the FR.

comment:11 Changed 11 years ago by fingolfin

Owner: changed from lavosspawn to eriktorbjorn

comment:12 Changed 11 years ago by eriktorbjorn

I've committed my patch to the trunk. (Not to the branch - it's a feature request, not a bug.)

comment:13 Changed 11 years ago by eriktorbjorn

Status: newclosed

comment:14 Changed 7 months ago by digitall

Component: Engine: Sword1
Game: Broken Sword 1
Note: See TracTickets for help on using tickets.