Opened 12 years ago

Closed 12 years ago

Last modified 8 months ago

#8741 closed patch

DETECTION: advanced detector engine simplification

Reported by: cyxx Owned by: sev-
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

Here is a patch to simplify the detection code of some engines relying on AdvancedDetector.

Currently, when an engine starts, AdvancedDetector::detectGameForEngineCreation is called, followed by AdvancedDetector::detectBestMatchingGame. Does running the detection process 2 times really necessary ?

Bsically, all this patch does is :
- replace any use of ADVANCED_DETECTOR_DEFINE_PLUGIN by ADVANCED_DETECTOR_DEFINE_PLUGIN_WITH_COMPLEX_CREATION
- removed detectGame/initGame helper functions in engines using ADVANCED_DETECTOR_DEFINE_PLUGIN_WITH_COMPLEX_CREATION (as the gameDescription is already available)
- add the missing call to upgradeTargetIfNecessary in ADVANCED_DETECTOR_DEFINE_PLUGIN_WITH_COMPLEX_CREATION
- remove the code related to detectGameForEngineCreation
- rename ADVANCED_DETECTOR_DEFINE_PLUGIN_WITH_COMPLEX_CREATION to ADVANCED_DETECTOR_DEFINE_PLUGIN

Ticket imported from: #1825276. Ticket imported from: patches/846.

Attachments (1)

advdetector-svn29385.diff (29.7 KB) - added by cyxx 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by cyxx

Attachment: advdetector-svn29385.diff added

comment:1 Changed 12 years ago by sev-

Excellent! Committed as is.

comment:2 Changed 12 years ago by sev-

Status: newclosed

comment:3 Changed 8 months ago by digitall

Component: --Other--
Note: See TracTickets for help on using tickets.