Opened 12 years ago

Closed 12 years ago

Last modified 12 months ago

#8732 closed patch

KYRA: Intro Patch for HoF

Reported by: athrxx Owned by: vinterstum
Priority: normal Component: Engine: Kyra
Keywords: Cc:
Game: Kyrandia 2

Description

Here is a patch for HoF that adds sequence player code for the intro. Timing is still an issue. Some "nested" WSAs will be cut off (e.g. Marco in the library). As discussed with Lord Hoto I assign this to vinterstum who might know how to fix this...

Florian

Ticket imported from: #1816080. Ticket imported from: patches/837.

Attachments (1)

kyra2intro_v4.patch (80.1 KB ) - added by athrxx 12 years ago.
KYRA: Intro Patch for Kyra 2

Download all attachments as: .zip

Change History (6)

by athrxx, 12 years ago

Attachment: kyra2intro_v4.patch added

KYRA: Intro Patch for Kyra 2

comment:1 by athrxx, 12 years ago

Owner: set to vinterstum

comment:2 by vinterstum, 12 years ago

Looks nice! I'll take a closer look at it over the weekend.

comment:3 by vinterstum, 12 years ago

Accepted and committed.

Nice work, thanks :).

A few pedantic notes it might be nice to consider for next time though, which would save me some work :) :
* Less hex (write 100 instead of 0x64), except in a few situations like when you're dealing with bitmasks etc)
* Use signed ints where it's obvious the original had 'em (-1 instead of 0xFFFF)
* More verbose variable names would be nice, 's', 's2', 'dl', 't' makes it a bit hard to read parts of the code. It may be obvious to you that 'cfid' is the current font id, but it won't be to other people reading it :).

Keeping stuff close to the disasm (like the first two points) is helpful when you're working with it, but the code should definately be given an overhaul once things are working and it's ready.

comment:4 by vinterstum, 12 years ago

Status: newclosed

comment:5 by digitall, 12 months ago

Component: Engine: Kyra
Game: Kyrandia 2
Note: See TracTickets for help on using tickets.