Opened 12 years ago

Closed 12 years ago

Last modified 12 months ago

#8704 closed patch

GUI: Reworked modern theme

Reported by: jvprat Owned by: sev-
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

After patch 1743196 I've begun reworking the modern theme so it shows correct separations between the widgets without the need of extra spaces in the strings. The result is attached.

I ended substituting numeric constants with variables to configure labels width and separations between widgets. It makes the widgets look better aligned and the different tabs look more homogeneous. The two attached screenshots show the difference in the audio tab.

This work is unfinished, just to know your opinion. I've just modified the modern theme (not the classic) and I've just worked with 2x mode. If you like this I can also rework the classic theme. I think the parameter variables would allow the modern theme to reuse bigger parts of the classic.

Ticket imported from: #1743201. Ticket imported from: patches/809.

Attachments (4)

clean_modern.patch (17.7 KB ) - added by jvprat 12 years ago.
before.png (24.3 KB ) - added by jvprat 12 years ago.
Audio tab before the change
after.png (24.3 KB ) - added by jvprat 12 years ago.
Audio tab after the change
popups.patch (861 bytes ) - added by jvprat 12 years ago.

Download all attachments as: .zip

Change History (12)

by jvprat, 12 years ago

Attachment: clean_modern.patch added

by jvprat, 12 years ago

Attachment: before.png added

Audio tab before the change

comment:1 by jvprat, 12 years ago

File Added: before.png

by jvprat, 12 years ago

Attachment: after.png added

Audio tab after the change

comment:2 by jvprat, 12 years ago

File Added: after.png

by jvprat, 12 years ago

Attachment: popups.patch added

comment:3 by jvprat, 12 years ago

I'm attaching a new patch that aligns all the widgets in the "game" tab. I'm using the same width of the other labels to leave enough room for translations. If you feel the old length was enough I could make the widgets above use the same variable (as it didn't appear in the theme it was harder for me to find it).
File Added: popups.patch

comment:4 by fingolfin, 12 years ago

Note that the "before.png" was clearly made after applying your patch #1743196, as in current SVN, there is a space after the labels on the "Audio" tab (though only on the popup labels, so it's inconsistent).

Anyway, this patch seems sensible enough (or as sensible as anything dealing with this theme INI hell could ever hope to be :). Of course the theme version would need to be incremented...

comment:5 by jvprat, 12 years ago

Oops, you're right, I forgot to remove that patch before doing the screenshot. Well, as it seems there's interest in a cleanup, I'll try to continue this work and unify it with the classic theme.

comment:6 by sev-, 12 years ago

Owner: set to sev-
Status: newclosed

comment:7 by sev-, 12 years ago

Excellent work! Committed both patches.

comment:8 by digitall, 12 months ago

Component: GUI
Note: See TracTickets for help on using tickets.