Opened 12 years ago

Closed 12 years ago

Last modified 8 months ago

#8651 closed patch

SCUMM: Fallback to Adlib when Roland Upgrade is missing

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:


This was discussed on #scummvm earlier today. Currently, EGA Loom and EGA Monkey Island 1 will both error out if the user has selected a MIDI music driver but the Roland Upgrade file(s) are missing.

Fingolfin added a TODO that we should handle this case more gracefully, I suggested a possible patch, and Kirben corrected my bone-headed mistakes. This is Kirben's version of the patch, with some minor changes.

What it does is to move the test for missing files to setupMusic(). This is where we determine which music driver to use, which is a bit earlier than we currently do it.

Ticket imported from: #1709681. Ticket imported from: patches/756.

Attachments (1)

adlib-fallback4.diff (2.5 KB) - added by eriktorbjorn 12 years ago.
Patch against current SVN

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by eriktorbjorn

Attachment: adlib-fallback4.diff added

Patch against current SVN

comment:1 Changed 12 years ago by eriktorbjorn

Owner: set to fingolfin

comment:2 Changed 12 years ago by fingolfin

Status: newclosed

comment:3 Changed 8 months ago by digitall

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.