Opened 13 years ago

Closed 13 years ago

Last modified 12 months ago

#8637 closed patch

Remove non-english characters from ym2612.cpp

Reported by: bluegr Owned by: fingolfin
Priority: normal Component: Port: Win32
Keywords: Cc:
Game:

Description

Hello

This is a small patch that removes some non-english characters from comments in ym2612.cpp, to fix a warning with MSVC8

The comments are written in Japanese (I think), which causes errors in Windows systems where the language is not set to Japanese. My system's language is in Greek, and when MSVC8 loads the file, it throws a warning that it contains non-english characters and asks the user to save it as Unicode. This stops the compilation

It's not a major issue, but since I don't think that those comments will be of use to everyone, and since this is an old version of softsynth, I've submitted this patch to remove those characters and make VS2005 happy (it is a hard thing to keep VS2005 happy, but that's another story). As I said, it's a minor patch, as the code itself is untouched, only some comments are removed.

Ticket imported from: #1701118. Ticket imported from: patches/742.

Attachments (1)

softsynth.patch (3.9 KB ) - added by bluegr 13 years ago.
Patch that removes non-english characters from comments in ym2612.cpp

Download all attachments as: .zip

Change History (4)

by bluegr, 13 years ago

Attachment: softsynth.patch added

Patch that removes non-english characters from comments in ym2612.cpp

comment:1 by fingolfin, 13 years ago

Owner: set to fingolfin
Status: newclosed

comment:2 by fingolfin, 13 years ago

Makes sense to remove these, I guess. Thanks.

comment:3 by digitall, 12 months ago

Component: Port: Win32
Note: See TracTickets for help on using tickets.