Opened 12 years ago

Closed 12 years ago

Last modified 10 months ago

#8625 closed patch

Scumm: Fix charset glitches in original Save-dialog

Reported by: SF/tobigun Owned by: Kirben
Priority: normal Component: Engine: SCUMM
Keywords: Cc:


The editing area of the original Save-dialog (Alt-F5) in the savegame name list is not drawn correctly. It reveals some graphical glitches which this patch fixes.

One reason for these bugs is the trimming of strings done in ScummEngine::drawString() which also trims spaces you enter when editing a savegame name.
Another cause is the buggy handling of empty strings ("") which are replaced by a string with one space (" "). Thats the reason why there is always shown a " " when you click on an empty slot.

This patch also works with the Grail Diary in Indy3 but I have not tested it with the MAC version.

Ticket imported from: #1687053. Ticket imported from: patches/730.

Attachments (1)

dialog_charset_glitch.patch (2.2 KB) - added by SF/tobigun 12 years ago.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by SF/tobigun

Attachment: dialog_charset_glitch.patch added

comment:1 Changed 12 years ago by Kirben

Owner: set to Kirben
Status: newclosed

comment:2 Changed 12 years ago by Kirben

I checked the disassembly of original games, and the trimming of excess spaces only applies to SCUMM4 and later games. So I adjusted the code in ScummVM to limit that section to SCUMM4 and later games, in order to fix those charset glitches.

I committed the other section of the patch to ScummVM SVN.

comment:3 Changed 12 years ago by fingolfin

Kirben took your patch as motivation to recheck assembly and made some changes to string.cpp accordingly. This the patch doesn't apply anymore... Not sure whether there is anything left in this patch which is not covered by Kirben's changes... Kirben?

comment:4 Changed 12 years ago by fingolfin

Status: closednew

comment:5 Changed 12 years ago by Kirben

Status: newclosed

comment:6 Changed 10 months ago by digitall

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.