Opened 12 years ago

Closed 12 years ago

Last modified 7 months ago

#8613 closed patch

DIMUSE: (Not) Storing mixer flags in savegames

Reported by: eriktorbjorn Owned by: eriktorbjorn
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

This patch isn't tested much, but it should break the unfortunate dependency on the exact values of the mixer flags that Fingolfin noted earlier today.

If it's applied, we should probably clarify some comments, and the comment in the mixer code could be removed or at least toned down a bit.

Ticket imported from: #1672572. Ticket imported from: patches/718.

Attachments (1)

imuse-mixer-flags.diff (5.9 KB) - added by eriktorbjorn 12 years ago.
Patch against current SVN

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by eriktorbjorn

Attachment: imuse-mixer-flags.diff added

Patch against current SVN

comment:1 Changed 12 years ago by eriktorbjorn

Owner: set to fingolfin
Summary: DIMUSE: Storing mixer flags in savegamesDIMUSE: (Not) Storing mixer flags in savegames

comment:2 Changed 12 years ago by fingolfin

Looks good to me. Feel free to commit it right away.

I think we should still say in mixer.h that it's not a good idea to store the mixer flags in the savegame, but the ref to iMuseDigital could indeed be removed-

comment:3 Changed 12 years ago by eriktorbjorn

Owner: changed from fingolfin to eriktorbjorn
Status: newclosed

comment:4 Changed 7 months ago by digitall

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.