Opened 13 years ago

Closed 13 years ago

Last modified 12 months ago

#8604 closed patch

BASS: various control panel fixes

Reported by: salty-horse Owned by: fingolfin
Priority: normal Component: Engine: Sky
Keywords: Cc:
Game: Beneath a Steel Sky

Description

The attached patch fixes:
* Bug https://sourceforge.net/support/tracker.php?aid=1548779 - wrong text on the FX button.
* Correct music_mute config key usage. The engine previously ignored it. Note that there's no ScummVM GUI for this option, so it's not toggle-able outside BASS.
* The yes/no dialog not restoring the mouse cursor to it's original state.

Ticket imported from: #1656801. Ticket imported from: patches/709.

Attachments (2)

sky-control.patch (4.5 KB ) - added by salty-horse 13 years ago.
sky-control2.patch (5.3 KB ) - added by salty-horse 13 years ago.
new version

Download all attachments as: .zip

Change History (7)

by salty-horse, 13 years ago

Attachment: sky-control.patch added

comment:1 by fingolfin, 13 years ago

As stated on IRC, this patch looks already pretty good, but causes a regression w.r.t. the look of the FX button (its "alight/dimmed" state should reflect whether FX are enabled or disabled -- this is the case in ScummVM currently, but doesn't work anymore with this patch).

by salty-horse, 13 years ago

Attachment: sky-control2.patch added

new version

comment:2 by salty-horse, 13 years ago

The previous patch removed the lighting of the buttons.
I restored that, and now the lights are also initialized correctly when showing the panel.
File Added: sky-control2.patch

comment:3 by fingolfin, 13 years ago

Owner: set to fingolfin
Status: newclosed

comment:4 by fingolfin, 13 years ago

Very nice, thanks a lot!

comment:5 by digitall, 12 months ago

Component: Engine: Sky
Game: Beneath a Steel Sky
Note: See TracTickets for help on using tickets.