Opened 14 years ago

Closed 14 years ago

Last modified 19 months ago

#8587 closed patch (fixed)

Segfault when destroying an engine twice

Reported by: jvprat Owned by: fingolfin
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

The Engine destructor deletes _saveFileMan, which is just a reference to a system object. If an engine fails to start, and you try to start it again (failing again), the second time the reference to _saveFileMan is invalid, and it segfaults when trying to delete it again. The attached patch solves it.

Ticket imported from: #1595240. Ticket imported from: patches/692.

Attachments (1)

segfault.patch (285 bytes ) - added by jvprat 14 years ago.
Don't delete _saveFileMan at Engine destruction

Download all attachments as: .zip

Change History (4)

by jvprat, 14 years ago

Attachment: segfault.patch added

Don't delete _saveFileMan at Engine destruction

comment:1 by fingolfin, 14 years ago

Owner: set to fingolfin
Resolution: fixed
Status: newclosed

comment:2 by fingolfin, 14 years ago

Thanks for pointing this out. I actually had planned to remove that "delete" when I moved the savefile manager -- but obviously I forgot :-(.

comment:3 by digitall, 19 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.