Opened 14 years ago

Closed 13 years ago

Last modified 17 months ago

#8571 closed patch

Make: reconfigure on configure change

Reported by: lordhoto Owned by: fingolfin
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

Hi,

this simple patch adds automatic reconfiguring if configure changes. I think it is understandable what it does. Any comments? I would remark that it would be nicer not to run configure with no paramaters if config.mk is missing, but my knowlegde of GNU make ends there. I hope it's any useful. I assign this one to Fingolfin since he works on the build system.

Ticket imported from: #1550165. Ticket imported from: patches/676.

Attachments (1)

build_sys.patch (1.2 KB ) - added by lordhoto 14 years ago.
patch against todays SVN

Download all attachments as: .zip

Change History (7)

by lordhoto, 14 years ago

Attachment: build_sys.patch added

patch against todays SVN

comment:1 by fingolfin, 14 years ago

Sorry, I was on vacation else I would have looked at this earlier ... :-)

The main issue with this patch is that the reconfigure is not complete: It does not store the values of the CPPFLAGS and LDFLAGS environment variables. Hence, on my system (which relies on those), the reconf fails (or rather, it fails to detect all the libraries, so while ScummVM still builds, it now is built w/o FLAC support, for example).

comment:2 by fingolfin, 13 years ago

I just noticed I once wrote a TODO list entry for this, too:

* Allow automatic re-runs of configure (this would have to 'save' the values of env vars like CXXFLAGS and also command line params).

comment:3 by fingolfin, 13 years ago

Status: newpending

comment:4 by SF/sf-robot, 13 years ago

This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker).

comment:5 by SF/sf-robot, 13 years ago

Status: pendingclosed

comment:6 by digitall, 17 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.