Opened 13 years ago

Closed 13 years ago

Last modified 10 months ago

#8544 closed patch

Leak in File::Open (on OS X) and unzOpen (on all)

Reported by: SF/madm00se Owned by: vinterstum
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

On Mac OS X File::Open does CFStringCreateWithBytes and
CFBundleCopyResourceURL. It does not CFRelease either
object returned.

unzOpen (in common/unzip.cpp) leaks if
us->file.open(path) fails.

I touched some indentation in unzOpen too.

Ticket imported from: #1503716. Ticket imported from: patches/649.

Attachments (1)

leaks-and-indentation.diff (1.6 KB) - added by SF/madm00se 13 years ago.
Leaks begone!

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by SF/madm00se

Attachment: leaks-and-indentation.diff added

Leaks begone!

comment:1 Changed 13 years ago by vinterstum

Applied, thanks :)

comment:2 Changed 13 years ago by vinterstum

Resolution: fixed
Status: newclosed

comment:3 Changed 10 years ago by Kirben

Owner: set to vinterstum

comment:4 Changed 10 years ago by Kirben

Resolution: fixed

comment:5 Changed 10 months ago by digitall

Component: --Other--
Note: See TracTickets for help on using tickets.