Opened 14 years ago

Closed 14 years ago

Last modified 21 months ago

#8522 closed patch

checking format strings in debug/error funcs

Reported by: SF/megath Owned by: fingolfin
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

small patch mantaining debug/error argument consistancy. (gcc only)

Ticket imported from: #1445422. Ticket imported from: patches/627.

Attachments (1)

format.patch (1.3 KB ) - added by SF/megath 14 years ago.
svn diff trunk/common/util.h

Download all attachments as: .zip

Change History (6)

by SF/megath, 14 years ago

Attachment: format.patch added

svn diff trunk/common/util.h

comment:1 by fingolfin, 14 years ago

That patch is not portable, I am afraid. You need to wrap __attribute__ with a macro, that you define to nothin for non-GCC compilers.

comment:2 by fingolfin, 14 years ago

I am sorry, I overlooked that you do that, however, I disagree with the way it's done -- redefining __attribute__ like that is not a good idea, since it exists on some other compilers, too, and a redefine may cause problems with e.g. system headers included after util.h

I have adapted your patch and commited it.

comment:3 by fingolfin, 14 years ago

Owner: set to fingolfin
Resolution: fixed
Status: newclosed

comment:4 by fingolfin, 14 years ago

Resolution: fixed

comment:5 by digitall, 21 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.