#8522 closed patch
checking format strings in debug/error funcs
| Reported by: | SF/megath | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | --Other-- |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
small patch mantaining debug/error argument consistancy. (gcc only)
Ticket imported from: #1445422. Ticket imported from: patches/627.
Attachments (1)
Change History (6)
by , 18 years ago
| Attachment: | format.patch added |
|---|
comment:1 by , 18 years ago
That patch is not portable, I am afraid. You need to wrap __attribute__ with a macro, that you define to nothin for non-GCC compilers.
comment:2 by , 18 years ago
I am sorry, I overlooked that you do that, however, I disagree with the way it's done -- redefining __attribute__ like that is not a good idea, since it exists on some other compilers, too, and a redefine may cause problems with e.g. system headers included after util.h
I have adapted your patch and commited it.
comment:3 by , 18 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:4 by , 18 years ago
| Resolution: | fixed |
|---|
comment:5 by , 5 years ago
| Component: | → --Other-- |
|---|
Note:
See TracTickets
for help on using tickets.
svn diff trunk/common/util.h