Opened 14 years ago

Closed 14 years ago

Last modified 21 months ago

#8520 closed patch

KYRA1: Game will crash if bitmap is missing

Reported by: SF/njoly Owned by: lordhoto
Priority: normal Component: Engine: Kyra
Keywords: Cc:
Game: Kyrandia 1

Description

Hi,

I noticed that scummvm will crash in KyraEngine::loadBitmap() if bitmap is missing.

I discovered this one because i forgot to copy *.CPS files from CD, and tried to run the game ... I can reproduce it at will if i remove the file `MAIN_FRE.CPS' from the game directory.

The attached patch adds and assertion to verify that the file was successfully loaded before trying to use it.

Hope this helps, Regards.

The legend of Kyrandia French CD version.

njoly@cixy [temp/scummvm]> scummvm -v ScummVM 0.9.0svn (Feb 24 2006 00:25:14) Features compiled in: MP3 zLib njoly@cixy [temp/scummvm]> uname -a NetBSD cixy.dial.pasteur.fr 3.99.15 NetBSD 3.99.15 (CIXY) #2: Tue Feb 21 01:39:35 CET 2006 njoly@cixy.dial.pasteur.fr:/local/src/NetBSD/obj/i386/sys/arch/i386/compile/CIXY i386

Ticket imported from: #1437774. Ticket imported from: patches/625.

Attachments (1)

scummvm-kyrabmp.diff (548 bytes ) - added by SF/njoly 14 years ago.

Download all attachments as: .zip

Change History (7)

by SF/njoly, 14 years ago

Attachment: scummvm-kyrabmp.diff added

comment:1 by fingolfin, 14 years ago

Owner: set to lordhoto

comment:2 by fingolfin, 14 years ago

LordHoto, can this patch be applied? Please comment!

comment:3 by lordhoto, 14 years ago

Status: newclosed

comment:4 by lordhoto, 14 years ago

Hi,

I thought we had that allready, maybe someone deleted it by accident, I'll commit that now as is. Sry I totally forgot about it.

Thanks for the patch then.

comment:5 by lordhoto, 14 years ago

Hi,

I thought we had that allready, maybe someone deleted it by accident, I'll commit that now as is. Sry I totally forgot about it.

Thanks for the patch then.

comment:6 by digitall, 21 months ago

Component: Engine: Kyra
Game: Kyrandia 1
Note: See TracTickets for help on using tickets.