Opened 15 years ago

Closed 15 years ago

Last modified 23 months ago

#8497 closed patch

KYRA: some little debugger fixes

Reported by: SF/clemty Owned by: lordhoto
Priority: normal Component: Engine: Kyra
Keywords: Cc:
Game:

Description

this patch will prevent users from entering invalid values for the "give" and "enter" command, thus preventing it from segfaulting.

also fixes the problem where when entering rooms 53 or 54 without parameter Brandon isn't visible.

if the debugger is reused this way in kyra2 or kyra3, additional checks need to be inserted to make sure it doesn't prevent the user from entering valid numbers in those games

Ticket imported from: #1393039. Ticket imported from: patches/602.

Attachments (4)

kyra_debuger_fix.diff (1.2 KB ) - added by SF/clemty 15 years ago.
diff file for the kyra debugger
kyra_debuger_fix.2.diff (845 bytes ) - added by SF/clemty 15 years ago.
updated version; fixed wrong comment and removed hardcoded room fix
kyra_debuger_fix_v3.diff (869 bytes ) - added by SF/clemty 15 years ago.
3rd version
kyra_debuger_fix_v4.diff (895 bytes ) - added by SF/clemty 15 years ago.
4th version

Download all attachments as: .zip

Change History (9)

by SF/clemty, 15 years ago

Attachment: kyra_debuger_fix.diff added

diff file for the kyra debugger

by SF/clemty, 15 years ago

Attachment: kyra_debuger_fix.2.diff added

updated version; fixed wrong comment and removed hardcoded room fix

by SF/clemty, 15 years ago

Attachment: kyra_debuger_fix_v3.diff added

3rd version

comment:1 by SF/clemty, 15 years ago

entering "give" without a parameter would crash ScummVM - fixed.

by SF/clemty, 15 years ago

Attachment: kyra_debuger_fix_v4.diff added

4th version

comment:2 by SF/clemty, 15 years ago

4th version does not use a hardcoded number of rooms anymore but gets it from the engine; at least the "enter" command should now also work with the other games

comment:3 by lordhoto, 15 years ago

Owner: set to lordhoto
Status: newclosed

comment:4 by lordhoto, 15 years ago

thanks for the patch

comment:5 by digitall, 23 months ago

Component: Engine: Kyra
Note: See TracTickets for help on using tickets.