Opened 14 years ago

Closed 14 years ago

Last modified 7 months ago

#8478 closed patch

BS2: Alignment fix, I hope

Reported by: eriktorbjorn Owned by: eriktorbjorn
Priority: normal Component: Engine: Sword2
Keywords: Cc:
Game: Broken Sword 2

Description

This patch is a rather extensive rewrite to get rid of
the reported alignment issues in the Broken Sword 2 engine.

I'm currently in the process of testing BS2 with it,
and have played my way to the warehouses in Marseille
without problem. However, it would be nice if someone
could try it on big-endian, because there is a good
chance I've introduced endian regressions.

And of course, it would be good to know if it actually
fixes the aforementioned alignment issues.

Ticket imported from: #1341495. Ticket imported from: patches/583.

Attachments (1)

bs2-alignment.diff.gz (59.5 KB) - added by eriktorbjorn 14 years ago.
Updated patch against an October 29 CVS snapshot

Download all attachments as: .zip

Change History (9)

comment:1 Changed 14 years ago by eriktorbjorn

Owner: set to SF/chrilith

Changed 14 years ago by eriktorbjorn

Attachment: bs2-alignment.diff.gz added

Updated patch against an October 29 CVS snapshot

comment:2 Changed 14 years ago by eriktorbjorn

Uploaded an updated patch. The first one wouldn't compile on
big-endian.

I've now reached the native village without noticing any
regressions.

comment:3 Changed 14 years ago by SF/damienguard

Tried the first few scenes, works just fine on 10.4.2. Also
tested load/save and cutscenes all without problem.

comment:4 Changed 14 years ago by SF/chrilith

Just tested the BS2 demo on zodiac 68k and ARM mode,
seems to work very well :)

great job !

comment:5 Changed 14 years ago by eriktorbjorn

Status: newclosed

comment:6 Changed 14 years ago by eriktorbjorn

Owner: changed from SF/chrilith to eriktorbjorn

comment:7 Changed 14 years ago by eriktorbjorn

I'm committing this, then, since the initial reports
indicate that I haven't completely broken things. It won't
be included in 0.8.0, but I imagine there'll be plenty of
time to deal with any remaining regressions before 0.9.0.

comment:8 Changed 7 months ago by digitall

Component: Engine: Sword2
Game: Broken Sword 2
Note: See TracTickets for help on using tickets.