Opened 14 years ago

Closed 13 years ago

Last modified 9 months ago

#8476 closed patch

MIDI gain setting for FluidSynth

Reported by: eriktorbjorn Owned by: sev-
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

This patch adds a "MIDI gain" setting, and uses it to
control the output level from the FluidSynth MIDI
driver. It should apply cleanly to both the trunk and
the branch. The main problem with it, as far as I know,
is that it won't fit into the MIDI tab with the small
version of the GUI.

See bug #1328632.

Ticket imported from: #1336171. Ticket imported from: patches/581.

Attachments (2)

midi-gain.diff (7.2 KB) - added by eriktorbjorn 14 years ago.
Patch against an October 25 CVS snapshot
midigain-gui.diff (4.5 KB) - added by eriktorbjorn 13 years ago.
Patch against current SVN

Download all attachments as: .zip

Change History (14)

Changed 14 years ago by eriktorbjorn

Attachment: midi-gain.diff added

Patch against an October 25 CVS snapshot

comment:1 Changed 14 years ago by eriktorbjorn

Not really assigning to Fingolfin in the sense that this is
his department, but I would like his input on it since it
does involve the GUI...

The main thing that's keeping me from doing anything about
this patch is the GUI issues, and that really depends on the
future plans for the GUI as well. I.e. is it worth the
trouble trying to make a GUI for this setting that also fits
in the small version of it?

Maybe I should just commit the non-GUI parts, and document
the setting? That way it could even go into 0.8.1 without
affecting anything except the FluidSynth driver...

comment:2 Changed 14 years ago by eriktorbjorn

Owner: set to fingolfin

comment:3 Changed 14 years ago by fingolfin

Owner: fingolfin deleted

comment:4 Changed 14 years ago by fingolfin

I'd separate the non-GUI and the GUI part, just like you
suggested yourself. Commit the non-GUI part, ideally also
updating the docs at the same time (README and docs/*.tex
stuff).

The new GUI (or should I say, new new GUI :-)) ... well this
is pretty much stalled at this time, I am afraid.

I haven't tried your patch yet, but the "Global options"
dialog has plenty of space on the MIDI tab. It's the "Edit
game" dialog which is too small, but nothing else (or am I
missing something). However, that dialog could easily be
made a lot bigger. In gui/launcher.cpp, line 154:
_h = screenH - 2 * 40; // TODO/FIXME

-> well just change the 40 to e.g. 10 and you gain 60 pixels
vertically, which should be enough for your needs, no?

comment:5 Changed 14 years ago by fingolfin

Oops, I meant line 160; and you'll also have to adjust _y etc.
But the idea should be clear, I hope :-)

comment:6 Changed 14 years ago by eriktorbjorn

The non-GUI part has been comitted, with some changes, to
both trunk and 0.8 branch. I'll take a look at the GUI part
later. Until then, the attached patch is, of course, out of
date.

comment:7 Changed 13 years ago by fingolfin

Any news on this?

comment:8 Changed 13 years ago by eriktorbjorn

Not really. As I said, I added the config setting, but then
the great GUI re-working began and it seemed better to wait
until things settled down. Though perhaps they have now...

Changed 13 years ago by eriktorbjorn

Attachment: midigain-gui.diff added

Patch against current SVN

comment:9 Changed 13 years ago by eriktorbjorn

Here's an attempt at adding a GUI setting for it.

comment:10 Changed 13 years ago by sev-

Thanks, committed.

comment:11 Changed 13 years ago by sev-

Owner: set to sev-
Status: newclosed

comment:12 Changed 9 months ago by digitall

Component: GUI
Note: See TracTickets for help on using tickets.