Opened 14 years ago

Closed 12 years ago

Last modified 5 months ago

#8461 closed patch

Showing the original save/load dialog (RFE #832460)

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

This patch allows Alt-F5 to bring up the original
save/load dialog in some games. It's not very useful
for saving/restoring, but it would allow people to see
their IQ points in Indiana Jones and the Last Crusade
without having to die first.

I have tried it with Maniac Mansion (v1 and v2), Zak
(v2), Indy3 (256-colour version) and CoMI. CoMI seems
to be the only one that doesn't work at the moment: it
crashes when trying to return to the game.

Ticket imported from: #1296058. Ticket imported from: patches/566.

Attachments (3)

iq-hack.diff (3.9 KB) - added by eriktorbjorn 14 years ago.
Patch against a September 20 CVS snapshot
iq-hack-alt.diff (888 bytes) - added by eriktorbjorn 14 years ago.
Alternative patch (using our GUI) against an October 10 CVS snapshot
iq-hack-updated.diff (3.2 KB) - added by eriktorbjorn 12 years ago.
Updated patch against current SVN

Download all attachments as: .zip

Change History (14)

Changed 14 years ago by eriktorbjorn

Attachment: iq-hack.diff added

Patch against a September 20 CVS snapshot

comment:1 Changed 14 years ago by eriktorbjorn

I forgot: It also works with EGA Loom.

comment:2 Changed 14 years ago by Kirben

Wouldn't it be easier to just display the IQ points in Indy3 by
our GUI? the original game seems to display the IQ points via
script 207 of room 14. Specifically using scum vars 244 &
245.

comment:3 Changed 14 years ago by eriktorbjorn

That was the other possible solution I suggested on the
scummvm-devel mailing list. The vast majority [1] favored
this way.

[1] Ok, ok, the one and only reply. ;-)

Changed 14 years ago by eriktorbjorn

Attachment: iq-hack-alt.diff added

Alternative patch (using our GUI) against an October 10 CVS snapshot

comment:4 Changed 14 years ago by eriktorbjorn

I've attached an alternative patch that uses our GUI.
However, I couldn't really say whether or not it works since
I don't remember how the IQ points are supposed to work. (I
could check my manual, but it's at the other side of town.)

Also, I can only test it against the English 256-colour PC
version. It hard-codes the English texts.

comment:5 Changed 14 years ago by Kirben

When I tried adding a custom GUI option in past, I noticed
SCUMM var 245 is only calculated when the original
load/save dialog is used. So we would need to copy that
calculation from the scripts, for the GUI option to be of any
use.

comment:6 Changed 12 years ago by fingolfin

The native save/load dialogs are not as powerful as our custom one, so one should always be able to reach that.

But we still might want to optionally show the original save/load dialog, simply for aesthetical/historical reason. Maybe we could add a "show original save/load dialog" button ? Since that might be a bit difficult, we could also simply reroute F6 to trigger the original save/load dialog, couldn't we? That way, we would have the best of both worlds, wouldn't we?

comment:7 Changed 12 years ago by fingolfin

Owner: set to fingolfin

comment:8 Changed 12 years ago by fingolfin

bleh, ignore the previous comment made by me -- I obviously didn't properly read this submission, else I would have noticed that Alt-F5 is used.

So, I'd like to get this into SVN soon. Unfortunately, the patch now is broken, as I refactored the code in input.cpp. I guess now we need to patch 2 or 3 spots to get this working again, but it would be nice to have nevertheless...

Changed 12 years ago by eriktorbjorn

Attachment: iq-hack-updated.diff added

Updated patch against current SVN

comment:9 Changed 12 years ago by eriktorbjorn

I've updated the patch to the point where it appears to work again, but feel free to correct and clean up, if necessary.

It looks as if the V8 "key script" variables are not stored in savegames, so it doesn't work properly for CMI. At least not when using the -x command-line option to restore an old savegame.
File Added: iq-hack-updated.diff

comment:10 Changed 12 years ago by fingolfin

Status: newclosed

comment:11 Changed 5 months ago by digitall

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.