#8461 closed patch
Showing the original save/load dialog (RFE #832460)
| Reported by: | eriktorbjorn | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
This patch allows Alt-F5 to bring up the original save/load dialog in some games. It's not very useful for saving/restoring, but it would allow people to see their IQ points in Indiana Jones and the Last Crusade without having to die first.
I have tried it with Maniac Mansion (v1 and v2), Zak (v2), Indy3 (256-colour version) and CoMI. CoMI seems to be the only one that doesn't work at the moment: it crashes when trying to return to the game.
Ticket imported from: #1296058. Ticket imported from: patches/566.
Attachments (3)
Change History (14)
by , 19 years ago
| Attachment: | iq-hack.diff added |
|---|
comment:2 by , 19 years ago
Wouldn't it be easier to just display the IQ points in Indy3 by our GUI? the original game seems to display the IQ points via script 207 of room 14. Specifically using scum vars 244 & 245.
comment:3 by , 19 years ago
That was the other possible solution I suggested on the scummvm-devel mailing list. The vast majority [1] favored this way.
[1] Ok, ok, the one and only reply. ;-)
by , 19 years ago
| Attachment: | iq-hack-alt.diff added |
|---|
Alternative patch (using our GUI) against an October 10 CVS snapshot
comment:4 by , 19 years ago
I've attached an alternative patch that uses our GUI. However, I couldn't really say whether or not it works since I don't remember how the IQ points are supposed to work. (I could check my manual, but it's at the other side of town.)
Also, I can only test it against the English 256-colour PC version. It hard-codes the English texts.
comment:5 by , 19 years ago
When I tried adding a custom GUI option in past, I noticed SCUMM var 245 is only calculated when the original load/save dialog is used. So we would need to copy that calculation from the scripts, for the GUI option to be of any use.
comment:6 by , 18 years ago
The native save/load dialogs are not as powerful as our custom one, so one should always be able to reach that.
But we still might want to optionally show the original save/load dialog, simply for aesthetical/historical reason. Maybe we could add a "show original save/load dialog" button ? Since that might be a bit difficult, we could also simply reroute F6 to trigger the original save/load dialog, couldn't we? That way, we would have the best of both worlds, wouldn't we?
comment:7 by , 18 years ago
| Owner: | set to |
|---|
comment:8 by , 18 years ago
bleh, ignore the previous comment made by me -- I obviously didn't properly read this submission, else I would have noticed that Alt-F5 is used.
So, I'd like to get this into SVN soon. Unfortunately, the patch now is broken, as I refactored the code in input.cpp. I guess now we need to patch 2 or 3 spots to get this working again, but it would be nice to have nevertheless...
comment:9 by , 18 years ago
I've updated the patch to the point where it appears to work again, but feel free to correct and clean up, if necessary.
It looks as if the V8 "key script" variables are not stored in savegames, so it doesn't work properly for CMI. At least not when using the -x command-line option to restore an old savegame. File Added: iq-hack-updated.diff
comment:10 by , 18 years ago
| Status: | new → closed |
|---|
comment:11 by , 6 years ago
| Component: | → Engine: SCUMM |
|---|
Patch against a September 20 CVS snapshot