Opened 15 years ago

Closed 15 years ago

Last modified 17 months ago

#8445 closed patch

Two small fix for descumm

Reported by: SF/albeu Owned by: fingolfin
Priority: normal Component: Tools
Keywords: Cc:
Game:

Description

First allow descumming v6 script with a size of 9. These are pretty common in dott: 8 bytes for the header plus one byte for the return op. Not so important but when one descumm a whole game it's nice to have all scripts, even if they are "empty".

Then fix the systemOps opcode, this one is wrong since long.

I also have some code to decode imuse commands and i could add a couple engine variable names (the GUI stuff). If you are intersted i'll submit that later.

Ticket imported from: #1234757. Ticket imported from: patches/550.

Attachments (1)

descumm_fix.diff (1.1 KB ) - added by SF/albeu 15 years ago.
Patch againts anonymous cvs 2005-07-08

Download all attachments as: .zip

Change History (5)

by SF/albeu, 15 years ago

Attachment: descumm_fix.diff added

Patch againts anonymous cvs 2005-07-08

comment:1 by fingolfin, 15 years ago

Owner: set to fingolfin
Status: newclosed

comment:2 by fingolfin, 15 years ago

Thanks, commited to CVS.

As for the engine variables: Depends on what exactly you mean. In general, we only add those vars to descumm which are used in ScummVM, i.e. those vars which have a meaning to the engine. We could of course compile tables for the other variables, too, but they are usually game specific, and even differ to a degree between different versions of a single game, so we tend not to bother.

Alas, I do not know what you have in mind precisely, so take this comment with a grain of salt!

comment:3 by SF/albeu, 15 years ago

I do mean variables used as interface to the engine (v6 only as useal with me). These are minor but imho it can be nice to have them.

Currently I found a bunch of variable that hold the strings used for menus, an array that have the colors for the menus, the debug password and a variable to set the game version (the engine then refuse to load saves with a mismatching version).

I tested them all with the original interpreter (v 6.4.3 Jul 10 1995 14:39:19) so i'm pretty sure they work. My test game also partially work with the samnmax interpreter (7.0.2 Jun 09 1994 13:52:31) and it show that at least the menu variables are the same.

I'll submit that as soon as i can update my cvs, so probably tomorrow :(

comment:4 by digitall, 17 months ago

Component: Tools
Note: See TracTickets for help on using tickets.