Opened 15 years ago

Closed 15 years ago

Last modified 12 months ago

#8416 closed patch

GOB: Possible inter_renewTimeInVars() fix

Reported by: eriktorbjorn Owned by: sev-
Priority: normal Component: Engine: Gob
Keywords: Cc:


This patch is pure guesswork, but...

I noticed there was some code to get current year,
month and date that had been commented out. This patch
re-enables that code and modifies it to work like the
one in the SCUMM engine, so it should be portable enough.

It also moves the code to inter_renewTimeInVars() and
changes that function to fill out the remaining time
variables with the current time rather than the amount
of time that has passed since ScummVM was started.

Does anyone know what variable 7 is supposed to
contain? It's currently always set to 0.

Ticket imported from: #1181639. Ticket imported from: patches/521.

Attachments (1)

gobtime.diff (1.7 KB ) - added by eriktorbjorn 15 years ago.
Patch against an April 12 CVS snapshot

Download all attachments as: .zip

Change History (7)

by eriktorbjorn, 15 years ago

Attachment: gobtime.diff added

Patch against an April 12 CVS snapshot

comment:1 by fingolfin, 15 years ago

Owner: set to sev-

comment:2 by wjp, 15 years ago

Setting variable 7 to 0 matches the disassembly. I have no
idea what the meaning of it is... maybe the game scripts
set/use it somewhere.

comment:3 by wjp, 15 years ago

one other comment: because we don't know what var7 is, it
might not be a good idea to set it to 0 in renewTimeVars().
Maybe only set it to 0 in game_playTot() where
renewTimeVars() is called?

comment:4 by sev-, 15 years ago

Status: newclosed

comment:5 by sev-, 15 years ago

Commited. Thanks.

comment:6 by digitall, 12 months ago

Component: Engine: Gob
Note: See TracTickets for help on using tickets.