Opened 15 years ago

Closed 15 years ago

Last modified 13 months ago

#8404 closed patch (outdated)

Reduce executable size on OSX by changing MT32 tables

Reported by: fingolfin Owned by: kingguppy
Priority: normal Component: Audio: MT32
Keywords: Cc:
Game:

Description

The attached patch turns one table of the MT32 emu from being an
static object into a heap allocated object. Result: my OSX binary
shrinks about 5 MB.

Since I don't have the required MT32 data files, I am submiting this
as a patch, as I can't gurantee that it doesn't break anything.

Ticket imported from: #1162111. Ticket imported from: patches/509.

Attachments (1)

mt32-mem.patch (2.8 KB ) - added by fingolfin 15 years ago.
The patch

Download all attachments as: .zip

Change History (9)

comment:1 by fingolfin, 15 years ago

Owner: set to kingguppy

comment:2 by fingolfin, 15 years ago

Note: another MB or so could be saved by turning some more of the tables
in tables.cpp into heap allocated objects.

comment:3 by sev-, 15 years ago

Err... no file attached :)

comment:4 by fingolfin, 15 years ago

Gah, I was just checking whether you guys pay attention *cough*... or
maybe I forgot to activate that checkbox... ;-)

by fingolfin, 15 years ago

Attachment: mt32-mem.patch added

The patch

comment:5 by kingguppy, 15 years ago

I've made most of the tables dynamically allocated in the
latest Munt CVS. Unfortunately this isn't quite ready for
release due to outstanding problems with the envelope
generation. As soon as I get a few more hours to work on it,
I'll fix those problems and merge the latest into ScummVM. I
was aware of this issue - sorry I didn't keep you updated on
the progress.

comment:6 by kingguppy, 15 years ago

I've merged the latest version of Munt (from CVS) into
ScummVM. All tables are now dynamically allocated.

comment:7 by kingguppy, 15 years ago

Resolution: outdated
Status: newclosed

comment:8 by digitall, 13 months ago

Component: Audio: MT32
Note: See TracTickets for help on using tickets.