Opened 15 years ago

Closed 15 years ago

Last modified 9 months ago

#8389 closed patch

LOOMCD: Workaround for typo in original game

Reported by: eriktorbjorn Owned by: eriktorbjorn
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Loom

Description

This patches works around a typo in the CD version of
Loom, where Chaos introduces herself to Mandible as
"Choas".

There are two reasons why I haven't just commited this
without asking. First of all, I don't know if there
were any non-English versions of LoomCD, and secondly I
don't know if we want to do this kind of fixes.

Ticket imported from: #1093830. Ticket imported from: patches/494.

Attachments (2)

loom-typo.diff (735 bytes) - added by eriktorbjorn 15 years ago.
Patch against a December 30 CVS snapshot
loomcd.s10 (10.5 KB) - added by eriktorbjorn 15 years ago.
Savegame before Chaos appears

Download all attachments as: .zip

Change History (6)

Changed 15 years ago by eriktorbjorn

Attachment: loom-typo.diff added

Patch against a December 30 CVS snapshot

Changed 15 years ago by eriktorbjorn

Attachment: loomcd.s10 added

Savegame before Chaos appears

comment:1 Changed 15 years ago by fingolfin

Well, we gotta be certain before we add stuff which changes game play,
but in this case, the fix is simple, and the issue it fixes is rather, uhmm,
embarrassing, so I don't mind it at all.

As for the implementation: I am pretty sure there were no non-english
versions of LoomCD. And even if there is, you are doing a memcmp, so
no harm done (I'd use a strcmp, though, it's clearer to understand I
think).

One request: Please add a "WORKAROUND" at the start of your
comment, like we use in other places (to make it clear that this is really
a well considered workaround for a problem; not just a random hack)

comment:2 Changed 15 years ago by eriktorbjorn

Well, normally we can't use strcmp() since the string can
contain embedded zeroes - at least that's my understanding -
but I guess that's not a problem in this particular case.

I'm applying the patch, with your proposed changes, as soon
as I've verified that it still works.

comment:3 Changed 15 years ago by eriktorbjorn

Owner: set to eriktorbjorn
Status: newclosed

comment:4 Changed 9 months ago by digitall

Component: Engine: SCUMM
Game: Loom
Note: See TracTickets for help on using tickets.