Opened 18 years ago
Closed 18 years ago
Last modified 5 years ago
#8389 closed patch
LOOMCD: Workaround for typo in original game
|Reported by:||eriktorbjorn||Owned by:||eriktorbjorn|
This patches works around a typo in the CD version of Loom, where Chaos introduces herself to Mandible as "Choas".
There are two reasons why I haven't just commited this without asking. First of all, I don't know if there were any non-English versions of LoomCD, and secondly I don't know if we want to do this kind of fixes.
Ticket imported from: #1093830. Ticket imported from: patches/494.
Change History (6)
by , 18 years ago
by , 18 years ago
Savegame before Chaos appears
comment:1 by , 18 years ago
Well, we gotta be certain before we add stuff which changes game play, but in this case, the fix is simple, and the issue it fixes is rather, uhmm, embarrassing, so I don't mind it at all.
As for the implementation: I am pretty sure there were no non-english versions of LoomCD. And even if there is, you are doing a memcmp, so no harm done (I'd use a strcmp, though, it's clearer to understand I think).
One request: Please add a "WORKAROUND" at the start of your comment, like we use in other places (to make it clear that this is really a well considered workaround for a problem; not just a random hack)
comment:2 by , 18 years ago
Well, normally we can't use strcmp() since the string can contain embedded zeroes - at least that's my understanding - but I guess that's not a problem in this particular case.
I'm applying the patch, with your proposed changes, as soon as I've verified that it still works.
comment:3 by , 18 years ago
|Status:||new → closed|
comment:4 by , 5 years ago
|Component:||→ Engine: SCUMM|
Patch against a December 30 CVS snapshot