Opened 15 years ago

Closed 15 years ago

Last modified 10 months ago

#8384 closed patch

GUI: Visible active tab

Reported by: salty-horse Owned by: fingolfin
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

The currently selected tab is not very noticable. The
following patch deletes the line below it, making it
and the dialog below it appear as one.

Stuff to think about:
* the tab change is done by deleting everything at the
bottom of the tab, including the blurred text beneath
it. It's not very noticable.
To change it, box() will have to be modified, perhaps
receiving flags that indicate which sides to draw (with
default "on" values, to prevent current code from
breaking)

* When a game settings dialog is open, the buttons from
the main dialog are still visible and appear as active.
Maybe the entire background should be blurred, and not
just the surface beneath the open dialog.

Ticket imported from: #1091165. Ticket imported from: patches/489.

Attachments (1)

gui.patch (920 bytes) - added by salty-horse 15 years ago.

Download all attachments as: .zip

Change History (4)

Changed 15 years ago by salty-horse

Attachment: gui.patch added

comment:1 Changed 15 years ago by fingolfin

Good idea with the tabs, but I prefer a clean implementation with respect
to transparency etc.. So I made an alternate patch, which uses a
modified box() function as you suggested. It's been applied to CVS.

As for the other suggestion: That's debatable. You can of course submit a
patch doing that, but it might be better to first discuss that with folks on
IRC/forums/the list/a feature request item.

comment:2 Changed 15 years ago by fingolfin

Owner: set to fingolfin
Status: newclosed

comment:3 Changed 10 months ago by digitall

Component: GUI
Note: See TracTickets for help on using tickets.