Opened 19 years ago

Closed 19 years ago

Last modified 6 years ago

#8384 closed patch

GUI: Visible active tab

Reported by: salty-horse Owned by: fingolfin
Priority: normal Component: GUI
Version: Keywords:
Cc: Game:


The currently selected tab is not very noticable. The following patch deletes the line below it, making it and the dialog below it appear as one.

Stuff to think about: * the tab change is done by deleting everything at the bottom of the tab, including the blurred text beneath it. It's not very noticable. To change it, box() will have to be modified, perhaps receiving flags that indicate which sides to draw (with default "on" values, to prevent current code from breaking)

* When a game settings dialog is open, the buttons from the main dialog are still visible and appear as active. Maybe the entire background should be blurred, and not just the surface beneath the open dialog.

Ticket imported from: #1091165. Ticket imported from: patches/489.

Attachments (1)

gui.patch (920 bytes ) - added by salty-horse 19 years ago.

Download all attachments as: .zip

Change History (4)

by salty-horse, 19 years ago

Attachment: gui.patch added

comment:1 by fingolfin, 19 years ago

Good idea with the tabs, but I prefer a clean implementation with respect to transparency etc.. So I made an alternate patch, which uses a modified box() function as you suggested. It's been applied to CVS.

As for the other suggestion: That's debatable. You can of course submit a patch doing that, but it might be better to first discuss that with folks on IRC/forums/the list/a feature request item.

comment:2 by fingolfin, 19 years ago

Owner: set to fingolfin
Status: newclosed

comment:3 by digitall, 6 years ago

Component: GUI
Note: See TracTickets for help on using tickets.