Opened 20 years ago

Closed 20 years ago

Last modified 6 years ago

#8375 closed patch

common/stream optimization

Reported by: SF/h00ligan Owned by: fingolfin
Priority: normal Component: --Other--
Version: Keywords:
Cc: Game:

Description

this patch introduce some optimization to common\stream module

Ticket imported from: #1082777. Ticket imported from: patches/480.

Attachments (1)

Stream.patch.bz2​ (1.4 KB ) - added by SF/h00ligan 20 years ago.
Stream.patch

Download all attachments as: .zip

Change History (7)

by SF/h00ligan, 20 years ago

Attachment: Stream.patch.bz2​ added

Stream.patch

comment:1 by sev-, 20 years ago

Summary: common\stream optimization → common/stream optimization

comment:2 by SF/h00ligan, 20 years ago

For me ReadStream and WriteStream looks like standart I/O inteface for stream. So it should consist of short simple methods gathered in declaretion section.

changes: - all methods defintion goes to header - some calls will run "faster" with inline e.g.: inline void writeSint32LE(int32 value) { writeUint32LE((uint32)value); } ... inline bool eof() const { return _pos == _bufSize; }

comment:3 by fingolfin, 20 years ago

Owner: set to fingolfin

comment:4 by fingolfin, 20 years ago

Status: new → closed

comment:5 by fingolfin, 20 years ago

I put a modified version of this patch into CVS. The inline keyword is not needed here, so I removed it. I also added some doxygen comments.

comment:6 by digitall, 6 years ago

Component: → --Other--
Note: See TracTickets for help on using tickets.