Opened 16 years ago

Closed 16 years ago

Last modified 21 months ago

#8357 closed patch

Possible fix for inttypes.h problem

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

The discussion on the mailing list seems to have fallen silent, so here's one possible way of dealing with the inttypes.h problem. As you can see, it simply adds a check for inttypes.h to the configure script and then uses the result from that to determine if it should include inttypes.h or if it should do its own typedeffing.

Mind you, the configure script already assumes that inttypes.h is present when it checks for libmpeg2, but I still thought it was more elegant to have a separate test for it.

Ticket imported from: #1040501. Ticket imported from: patches/462.

Attachments (2)

inttypes.diff (1.7 KB ) - added by eriktorbjorn 16 years ago.
Patch against an October 5 CVS snapshot
inttypes2.diff (1.2 KB ) - added by eriktorbjorn 16 years ago.
Alternative patch against an October 16 CVS snapshot

Download all attachments as: .zip

Change History (6)

by eriktorbjorn, 16 years ago

Attachment: inttypes.diff added

Patch against an October 5 CVS snapshot

comment:1 by fingolfin, 16 years ago

Hm, why use HAVE_INTTYPES at all? Why not just always use those typedefs?

by eriktorbjorn, 16 years ago

Attachment: inttypes2.diff added

Alternative patch against an October 16 CVS snapshot

comment:2 by eriktorbjorn, 16 years ago

As long as we only use inttypes.h to keep mpeg2.h happy, I guess HAVE_INTTYPES isn't needed, and this option was one of the reasons I didn't commit the patch. I figured whichever way I went someone would ask "but why didn't you...?", but I was too lazy then to do both. :-)

I've attached an alternative patch now, though.

comment:3 by fingolfin, 16 years ago

Owner: set to fingolfin
Status: newclosed

comment:4 by digitall, 21 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.