Opened 16 years ago

Closed 16 years ago

Last modified 23 months ago

#8343 closed patch

Fix (I hope) for problems with MISEGACD sound assertion

Reported by: SF/lord_nightmare Owned by: SF/khalek
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 1

Description

I didn't account for the fact that sounds can be demangled multiple times in the SegaCD Monkey Island, causing them to trigger the assertion immediately below the new demangling code. This patch SHOULD fix it, I HOPE. It may not be the CORRECT way to do this (Fingolfin suggested allocating a seperate buffer for the demangled sounds instead of demangling them in place, and I think all the sounds should be demangled on game load rather than the first time they're played) but it should work.

Lord Nightmare

Ticket imported from: #959129. Ticket imported from: patches/448.

Attachments (1)

sound.cpp.diff (487 bytes ) - added by SF/lord_nightmare 16 years ago.
Patch for sound.cpp to fix the assertion

Download all attachments as: .zip

Change History (4)

by SF/lord_nightmare, 16 years ago

Attachment: sound.cpp.diff added

Patch for sound.cpp to fix the assertion

comment:1 by SF/khalek, 16 years ago

Owner: set to SF/khalek
Status: newclosed

comment:2 by SF/khalek, 16 years ago

Seeing as they are already demangled in place and this apparently fixes assertions that prevent the game from being playable I've applied it.

comment:3 by digitall, 23 months ago

Component: Engine: SCUMM
Game: Monkey Island 1
Note: See TracTickets for help on using tickets.