#8343 closed patch
Fix (I hope) for problems with MISEGACD sound assertion
| Reported by: | SF/lord_nightmare | Owned by: | SF/khalek |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Monkey Island 1 |
Description
I didn't account for the fact that sounds can be demangled multiple times in the SegaCD Monkey Island, causing them to trigger the assertion immediately below the new demangling code. This patch SHOULD fix it, I HOPE. It may not be the CORRECT way to do this (Fingolfin suggested allocating a seperate buffer for the demangled sounds instead of demangling them in place, and I think all the sounds should be demangled on game load rather than the first time they're played) but it should work.
Lord Nightmare
Ticket imported from: #959129. Ticket imported from: patches/448.
Attachments (1)
Change History (4)
by , 20 years ago
| Attachment: | sound.cpp.diff added |
|---|
comment:1 by , 20 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:2 by , 20 years ago
Seeing as they are already demangled in place and this apparently fixes assertions that prevent the game from being playable I've applied it.
comment:3 by , 5 years ago
| Component: | → Engine: SCUMM |
|---|---|
| Game: | → Monkey Island 1 |
Note:
See TracTickets
for help on using tickets.
Patch for sound.cpp to fix the assertion