Opened 20 years ago

Closed 20 years ago

Last modified 6 years ago

#8340 closed patch

Various Console fixes

Reported by: wjp Owned by: eriktorbjorn
Priority: normal Component: --Other--
Version: Keywords:
Cc: Game:


The attached patch should fix most of the problems that occur when the Console buffer overflows and wraps back to the start and some related issues:

* new lines are now cleared * scrollbar now works correctly after a wraparound * home/end now move the cursor to the start/end of the current prompt * shift+home/end move the window to the top/bottom * shift+pageup/pagedown move the window up/down a page

I renamed the function updateScrollBar to updateScrollBuffer because it now also updated some state not directly related to the scrollbar.

Ticket imported from: #956989. Ticket imported from: patches/445.

Attachments (1)

scummvm_console.patch (4.9 KB ) - added by wjp 20 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by wjp, 20 years ago

This should fix bugs #941811 and #941814.

comment:2 by eriktorbjorn, 20 years ago

Owner: set to fingolfin

comment:3 by fingolfin, 20 years ago

Owner: fingolfin removed

comment:4 by fingolfin, 20 years ago

Owner: set to eriktorbjorn

comment:5 by fingolfin, 20 years ago

I only glanced over the code, it appears OK. But I haven't tested it. Still I trust wjp to only produce high quality patches 8-). Erik, feel free to try out if this fixes your issues (at least partially), and if it does work fine for you, apply it yourself -- don't see why I should act as a proxy in this matter ;-)

by wjp, 20 years ago

Attachment: scummvm_console.patch added


comment:6 by wjp, 20 years ago

Minor update: in the constructor printf() was used before all variables were initialized & some cleanup.

comment:7 by eriktorbjorn, 20 years ago

It does seem to fix those bugs, yes. Applied.

comment:8 by eriktorbjorn, 20 years ago

Status: newclosed

comment:9 by digitall, 6 years ago

Component: --Other--
Note: See TracTickets for help on using tickets.