Opened 15 years ago

Closed 15 years ago

Last modified 10 months ago

#8340 closed patch

Various Console fixes

Reported by: wjp Owned by: eriktorbjorn
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

The attached patch should fix most of the problems that
occur when the Console buffer overflows and wraps back
to the start and some related issues:

* new lines are now cleared
* scrollbar now works correctly after a wraparound
* home/end now move the cursor to the start/end of the
current prompt
* shift+home/end move the window to the top/bottom
* shift+pageup/pagedown move the window up/down a page

I renamed the function updateScrollBar to
updateScrollBuffer because it now also updated some
state not directly related to the scrollbar.

Ticket imported from: #956989. Ticket imported from: patches/445.

Attachments (1)

scummvm_console.patch (4.9 KB) - added by wjp 15 years ago.
scummvm_console.patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 15 years ago by wjp

This should fix bugs #941811 and #941814.

comment:2 Changed 15 years ago by eriktorbjorn

Owner: set to fingolfin

comment:3 Changed 15 years ago by fingolfin

Owner: fingolfin deleted

comment:4 Changed 15 years ago by fingolfin

Owner: set to eriktorbjorn

comment:5 Changed 15 years ago by fingolfin

I only glanced over the code, it appears OK. But I haven't tested it. Still I
trust wjp to only produce high quality patches 8-). Erik, feel free to try
out if this fixes your issues (at least partially), and if it does work fine
for you, apply it yourself -- don't see why I should act as a proxy in this
matter ;-)

Changed 15 years ago by wjp

Attachment: scummvm_console.patch added

scummvm_console.patch

comment:6 Changed 15 years ago by wjp

Minor update: in the constructor printf() was used before
all variables were initialized & some cleanup.

comment:7 Changed 15 years ago by eriktorbjorn

It does seem to fix those bugs, yes. Applied.

comment:8 Changed 15 years ago by eriktorbjorn

Status: newclosed

comment:9 Changed 10 months ago by digitall

Component: --Other--
Note: See TracTickets for help on using tickets.