Opened 16 years ago

Closed 16 years ago

Last modified 23 months ago

#8339 closed patch (wontfix)

Wrong language in BS1 game menu.

Reported by: SF/mysunk Owned by: lavosspawn
Priority: normal Component: Engine: Sword1
Keywords: Cc:
Game: Broken Sword 1

Description

Wrong language in BS1 game menu. patch -p0 < patch.diff in /sword1 directory to patch control.cpp

Ticket imported from: #941433. Ticket imported from: patches/444.

Attachments (1)

patch.diff (453 bytes ) - added by SF/mysunk 16 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by fingolfin, 16 years ago

Besides the fact that there is no patch file attached to this tracker item, it would be wise if you explained what your patch is supposed to do...

by SF/mysunk, 16 years ago

Attachment: patch.diff added

comment:2 by eriktorbjorn, 16 years ago

Owner: set to lavosspawn

comment:3 by eriktorbjorn, 16 years ago

I assume this has to do with the Czech or Portuguese (?) versions, since the original line would seem to make sure that BS1_CZECH and BS1_PORT are never used. But replacing MIN( X, Y ) with MIN( X, X ) seems like an awkward way of doing it...

I don't know why these languages are disabled, though. Could be lack of testing, or it could be some deeper problem.

comment:4 by fingolfin, 16 years ago

What is the status of this item?

comment:5 by eriktorbjorn, 16 years ago

Unchanged, I guess. Lavosspawn / Cody56 has always been idle when I've been on IRC lately, so I haven't asked him, and I'm still not clear on what the patch tries to do.

comment:6 by lavosspawn, 16 years ago

I can't test this, as I don't have a Czech BS1 version. The Czech and Portuguese control panels are disabled in our source; just like they were in the sources we got from Revolution. I've slightly changed the source to use the Czech background image and texts and sent a precompiled exe to the reporter of bug report #990797, asking him to test it (though he didn't tell his OS...) and am now waiting for his reply.

comment:7 by lavosspawn, 16 years ago

Resolution: wontfix
Status: newclosed

comment:8 by lavosspawn, 16 years ago

support for these languages was meant to be disabled.

comment:9 by digitall, 23 months ago

Component: Engine: Sword1
Game: Broken Sword 1
Note: See TracTickets for help on using tickets.