Opened 19 years ago
Closed 19 years ago
Last modified 4 years ago
#8335 closed patch
FOTAQ - additional hebrew support
|Reported by:||salty-horse||Owned by:|
|Cc:||Game:||Flight of the Amazon Queen|
* Fixed reverse order of lines in dialogue chooser, when one sentence is "wrapped" over several lines <queen/talk.cpp> * Fixed "save entry" text in the journal (originally appears, even in the exe, as "entry save") <queen/journal.cpp>
The code in talk.cpp is a bit messy, I'd appriciate any feedback.
note: The patch is for the cvs HEAD.
Ticket imported from: #910779. Ticket imported from: patches/440.
Change History (7)
by , 19 years ago
comment:1 by , 19 years ago
comment:2 by , 19 years ago
What is the status of this item?
comment:3 by , 19 years ago
We're waiting for an updated (rewritten ?) patch from the original submitter.
comment:4 by , 19 years ago
It will be done this weekend.
comment:5 by , 19 years ago
|Status:||new → closed|
comment:6 by , 4 years ago
|Component:||→ Engine: Queen|
|Game:||→ Flight of the Amazon Queen|
Note: See TracTickets for help on using tickets.
You want some feedback, here it is :-).
As a comparaison, I looked at the original implementation of split_option() in the hebrew executable. A 'C' rewrite is here : http://membres.lycos.fr/cyxdown/scummvm/fotaq/split_option _heb.cpp
Another (purely cosmetic) suggestion is to add to the Talk class 2 methods to split the option lines (ie, one for reversed/hebrew and one for default/english). Then, Talk::splitOption() would simply have to call the appropriate function.