Opened 16 years ago

Closed 16 years ago

Last modified 13 months ago

#8296 closed patch

FT: PC demo bugfixes

Reported by: sev- Owned by: Kirben
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Full Throttle

Description

PC FT demo didn't work well with current scummvm. It
crashed right after beginning video sequence with
complains about wrong script number.

This patch fixes it. Also further work showed that
INSANE is different in the demo, so there is just minor
fix for it that it doesn't crash.

There are many graphics glitches like:
o Actors' animation often goes in wrong direction
o Some video sequences do not play. There is sound
but no
picture
o It crashed at the final sequence with random
illegal opcode.
But it is still possible to skip it with pressing ESC
o After demo is looped LA logo is shown in wrong position

This patch relies on that assuption that Ender will
rename Mac
demo to ftmacdemo as it was discussed on IRC.

I will work at demo issues later after my next big
patch will be finished.

Ticket imported from: #839741. Ticket imported from: patches/401.

Attachments (2)

ftdemofix.patch (8.8 KB ) - added by sev- 16 years ago.
Fixed Patch to make PC FT demo run
ftdemofix.2.patch (8.7 KB ) - added by sev- 16 years ago.
Fixed patch to make both PC and Mac FT demo coexist

Download all attachments as: .zip

Change History (7)

comment:1 by fingolfin, 16 years ago

Actually if Ender should perform such a rename, your patch will
not apply cleanly anymore, since you also modified the ftdemo
target. SO, why not add that new target yourself to
scummvm.cpp and upload a new patch? :-)

Please make sure to use tabs, not spaces, for indention.

by sev-, 16 years ago

Attachment: ftdemofix.patch added

Fixed Patch to make PC FT demo run

comment:2 by sev-, 16 years ago

Fixed patch is attached

by sev-, 16 years ago

Attachment: ftdemofix.2.patch added

Fixed patch to make both PC and Mac FT demo coexist

comment:3 by sev-, 16 years ago

Well, as now I have Mac FT demo as well, I checked this
patch against it and found that it breaks it.

The problem is when Mac demo becomes ftmacdemo target, it
will look for file ftmacdemo.la0, which doesn't exist, of
course.

There are two ways, either add another hard-coded resource
file name as it is already done with PC demo or rename
pcdemo. I did the latter and now pc demo is 'ftpcdemo', and
Mac demo is still 'ftdemo'. I personally don't like this
approach, there is a real need to get rid of that connection
between target and main resource name, but at least latest
patch will not break any .scummvmrc file.

I will leave last patch undeleted to clearly see the difference.

comment:4 by Kirben, 16 years ago

Owner: set to Kirben
Status: newclosed

comment:5 by digitall, 13 months ago

Component: Engine: SCUMM
Game: Full Throttle
Note: See TracTickets for help on using tickets.