Opened 16 years ago

Closed 16 years ago

Last modified 12 months ago

#8278 closed patch (wontfix)

new/modified scaler

Reported by: (none) Owned by: fingolfin
Priority: normal Component: Graphics: Scalers
Keywords: Cc:
Game:

Description

In played a little with the mameadv2x scaler and modified
it to add some new features:

-- it removes dither patterns
-- it blurs areas with many different colors

Furthermore it shouldn't be much slower than the original
scale2x and could possibly be used 2 times in a row as an
scale4x scaler.

Therefore I wonder if you could implement this algorithm.

Ticket imported from: #815251. Ticket imported from: patches/383.

Attachments (1)

scaler.cpp.txt (1.8 KB ) - added by SF/*anonymous 16 years ago.
The code snipet containing the modified scaler

Download all attachments as: .zip

Change History (9)

by SF/*anonymous, 16 years ago

Attachment: scaler.cpp.txt added

The code snipet containing the modified scaler

comment:1 by eriktorbjorn, 16 years ago

(This should probably be moved to the patch tracker, but I
don't know how to do that.)

Looks like it could be useful for games like EGA Loom.
Assigning to Fingolfin since he's done a lot of scaler work
lately.

comment:2 by eriktorbjorn, 16 years ago

Owner: set to fingolfin

comment:3 by fingolfin, 16 years ago

Owner: fingolfin removed

comment:4 by fingolfin, 16 years ago

Some problems with this:
* it's not a patch (although I could work around that easily
enough)
* avg() is slow and only works on 565 modes. Solution: use
INTERPOLATE as given in common/scaler/2xsai.cpp
* instead of this: avg(col,avg(near1,near2)) use more efficient
code. Essentially, you want:
Q_INTERPOLATE(col, col, near1, near2)
* the scaler function is called AdvMame2x, even though it's *not*
AdvMame2x :-)

I can look into applying these changes myself a bit later and test
it, and then if the results are OK, we could accept the filter. But
since so far I didn't try it, I can't judge how it measures up to
other scalers.

comment:5 by fingolfin, 16 years ago

Owner: set to fingolfin

comment:6 by fingolfin, 16 years ago

I have implemented the algorithm, but I really couldn't find any place
where it wasn't beat either by advmame2x, hq2x, or another of the 2x
filters. A matter of taste, maybe, but overall we have the policy of not
adding any new filters unless they have a very clear advantage in a
specific game. That doesn't seem to be the case here.

comment:7 by fingolfin, 16 years ago

Resolution: wontfix
Status: newclosed

comment:8 by digitall, 12 months ago

Component: Graphics: Scalers
Note: See TracTickets for help on using tickets.