Opened 16 years ago

Closed 16 years ago

Last modified 12 months ago

#8275 closed patch (outdated)

Win32 - search for .INI in program path first

Reported by: SF/quietust Owned by: fingolfin
Priority: normal Component: Port: Win32
Keywords: Cc:
Game:

Description

The WINDOWS/WINNT directory is generally rather
cluttered. The attached patch allows
placing 'scummvm.ini' in the current working directory
(this will generally be the same location as
scummvm.exe, sdl.dll, etc.); if the file is not found
there, it will default to the Windows directory as it
usually does.

With several minor changes [use GetModuleFileName
(NULL,...) instead of GetCurrentDirectory(...) and strip
off the filename], this could be made to check the .EXE
directory instead of the current directory, making it even
more portable.

Ticket imported from: #795066. Ticket imported from: patches/380.

Attachments (1)

win_cfg_progdir.diff (875 bytes ) - added by SF/quietust 16 years ago.
Search for SCUMMVM.INI in program directory

Download all attachments as: .zip

Change History (12)

comment:1 by SF/quietust, 16 years ago

Altered patch, now searches in the same directory in which
the EXE resides

by SF/quietust, 16 years ago

Attachment: win_cfg_progdir.diff added

Search for SCUMMVM.INI in program directory

comment:2 by SF/quietust, 16 years ago

Summary: Win32 - search for .INI in current dir firstWin32 - search for .INI in program path first

comment:3 by fingolfin, 16 years ago

Kirben, you are a windows user, what is your opinion on this?

comment:4 by fingolfin, 16 years ago

Owner: set to Kirben

comment:5 by Kirben, 16 years ago

Owner: Kirben removed

comment:6 by Kirben, 16 years ago

I'm against the change, it is better to keep the ScummVM
config file in a central location and allowing multiple locations
for the ScummVM config file could confuse users.

comment:7 by SF/jamieson630, 16 years ago

http://sourceforge.net/tracker/index.php?
func=detail&aid=743288&group_id=37116&atid=418823 for
more discussion on this (including my feelings on the matter).

comment:8 by fingolfin, 16 years ago

Owner: set to fingolfin

comment:9 by fingolfin, 16 years ago

This patch is outdated, and won't apply anymore. Although, it's not
really the proper solution to the problem. Though we might be
able to reuse parts of it for the "real thing" :-)

comment:10 by fingolfin, 16 years ago

Resolution: outdated
Status: newclosed

comment:11 by digitall, 12 months ago

Component: Port: Win32
Note: See TracTickets for help on using tickets.