Opened 21 years ago

Closed 21 years ago

Last modified 6 years ago

#8269 closed patch

Resampling in extract / simon2mp3 no longer needed?

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Tools
Version: Keywords:
Cc: Game:


As far as I can tell, the recent mixer changes removes the need for the extract and simon2mp3 utilities to resample the sound data to 22 kHz before encoding.

This makes quite a noticeable difference in the size of the resulting files for FOA and Simon 2, where most (all?) sounds are 11 kHz. For the other games there is little or no change, but since oggenc seems to have problems with resampling (for me at least), this may be a good way to eliminate those problems once and for all.

Ticket imported from: #788860. Ticket imported from: patches/374.

Attachments (1)

no_resample.diff (2.3 KB ) - added by eriktorbjorn 21 years ago.
Patch against an August 13 CVS snapshot

Download all attachments as: .zip

Change History (6)

by eriktorbjorn, 21 years ago

Attachment: no_resample.diff added

Patch against an August 13 CVS snapshot

comment:1 by eriktorbjorn, 21 years ago

Of course, this would have to be reconsidered if we ever implement feature request #786569 ("Fix for codebook waste and resampling issues").

For all practical purposes, there seem to be only two sample rates to worry about though: 11 kHz and 22 kHz. Maybe we could split the original file into two, one for each frequency?

comment:2 by eriktorbjorn, 21 years ago

Owner: set to fingolfin

comment:3 by eriktorbjorn, 21 years ago

Assigning to Fingolfin, since he's doing the mixer changes. (But feel free to unassign yourself!)

comment:4 by Kirben, 21 years ago

Status: newclosed

comment:5 by digitall, 6 years ago

Component: Tools
Note: See TracTickets for help on using tickets.