Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#8232 closed patch

Zak: Fix for printing strings in V2

Reported by: SF/hoenicke Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Zak McKracken

Description

In Zak Exit-Visa code is broken, since the print opcode 7 has a different meaning there. The same is true for MM.

Attached is the necessary fix for string.cpp.

Ticket imported from: #742851. Ticket imported from: patches/337.

Attachments (1)

string.cpp.diff (640 bytes ) - added by SF/hoenicke 18 years ago.
Patch to string.cpp

Download all attachments as: .zip

Change History (6)

by SF/hoenicke, 18 years ago

Attachment: string.cpp.diff added

Patch to string.cpp

comment:1 by fingolfin, 18 years ago

This patch is not correct. You have been mislead by the naming of GF_AFTER_V3 - it is *NOT* set for any V4/v5 games, so your patch would break those. Rather check for V2 and make your change only for V2.

But anyway, I am not convinced this change is correct (but that doesn't mean it isn't - just have to check :-)

comment:2 by fingolfin, 18 years ago

I put an alternate implementation into CVS. Can you check if that works for you?

comment:3 by SF/hoenicke, 18 years ago

There's a var++ missing in the loop. After fixing that it works.

comment:4 by fingolfin, 18 years ago

Owner: set to fingolfin
Status: newclosed

comment:5 by digitall, 2 years ago

Component: Engine: SCUMM
Game: Zak McKracken
Note: See TracTickets for help on using tickets.