Experimental costume.cpp cleanup
|Reported by:||eriktorbjorn||Owned by:||fingolfin|
Something I've been wondering about for a long time now is whether or not we actually need all the different proc*() functions in costume.cpp. As far as I can tell, they're all the same function, optimized for different circumstances.
But is that optimization noticeable on today's hardware? If not, all they do is to make the code less maintainable.
This patch removes all the proc*() functions, except one which has been slightly extended. I don't know if making this change is a good idea or not, but I think it's worth discussing. It would cut the size of costume.cpp to about half its current size.
Mind you, I haven't tested this very much yet. In particular, I don't have any of the Amiga data files, so I may very well have broken those games horribly.
Ticket imported from: #738859. Ticket imported from: patches/330.
Change History (9)
comment:5 by , 17 years ago
|Status:||new → closed|
|Summary:||Experimental costume.cpp cleanup (don't apply) → Experimental costume.cpp cleanup|